You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2024/12/09 19:34:38 UTC
[PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
kwin opened a new pull request, #216:
URL: https://github.com/apache/maven-site-plugin/pull/216
with the project
Consider those site-resource archives when setting up the site context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#discussion_r1877676339
##########
src/main/java/org/apache/maven/plugins/site/SiteResourcesAttachMojo.java:
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.project.MavenProjectHelper;
+import org.codehaus.plexus.archiver.Archiver;
+import org.codehaus.plexus.archiver.ArchiverException;
+import org.codehaus.plexus.archiver.FileSet;
+import org.codehaus.plexus.archiver.util.DefaultFileSet;
+
+/**
+ * Adds the site resources (compressed in a ZIP archive) as dedicated artifact with classifier {@value #CLASSIFIER} to be installed/deployed.
+ * Usually used in combination with {@link org.apache.maven.plugins.site.descriptor.SiteDescriptorAttachMojo} to also deploy the actual site descriptor.
+ * This is used for sites inheriting from this project
+ *
+ * @since next
+ */
+@Mojo(name = SiteResourcesAttachMojo.GOAL_NAME, defaultPhase = LifecyclePhase.PACKAGE, threadSafe = true)
+public class SiteResourcesAttachMojo extends AbstractSiteMojo {
+
+ public static final String GOAL_NAME = "attach-site-resources";
+
+ /**
+ * Directory containing the <code>site.xml</code> file and the source for hand written docs (one directory
+ * per Doxia-source-supported markup types)
+ * @see <a href="/doxia/references/index.html">Doxia Markup Languages References</a>.
+ */
+ @Parameter(defaultValue = "${basedir}/src/site")
+ protected File siteDirectory;
+
+ /**
+ * Maven ProjectHelper.
+ */
+ @Component
+ private MavenProjectHelper projectHelper;
+
+ @Component(hint = ARCHIVE_EXTENSION)
+ private Archiver zipArchiver;
+
+ /**
+ * The file name patterns to exclude (potentially in addition to the default ones mentioned at {@link #addDefaultExcludes}).
+ * The format of each pattern is described in {@link org.codehaus.plexus.util.DirectoryScanner}.
+ * The comparison is performed against the file path relative to the {@link #siteDirectory}.
+ * <p>
+ * Each value is either a regex pattern if enclosed within {@code %regex[} and {@code ]}, otherwise an
+ * <a href="https://ant.apache.org/manual/dirtasks.html#patterns">Ant pattern</a>.
+ * Exclusions take precedence over inclusions via {@link #includes}.
+ */
+ @Parameter(defaultValue = "**/.gitignore,**/.gitattributes", required = true)
Review Comment:
Only true for `.gitignore` (https://github.com/codehaus-plexus/plexus-utils/blob/349b89ced5c863d0dc2c637d30d08b556265efec/src/main/java/org/codehaus/plexus/util/AbstractScanner.java#L109). Will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "kwin (via GitHub) via issues" <is...@maven.apache.org>.
kwin commented on PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#issuecomment-6628407233
@slachiewicz Feel free to take over, I think it is still relevant and would be a welcome addition. However, I won't have time for this in the foreseeable future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "slachiewicz (via GitHub) via issues" <is...@maven.apache.org>.
slachiewicz commented on PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#issuecomment-6635702611
Carried onto the 3.x line in #1352, with your commit kept as authored and the 3.x adaptation, the fix for the duplicate documents and the review remarks in separate commits on top. Thanks, @kwin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#discussion_r1877637374
##########
src/main/java/org/apache/maven/plugins/site/SiteResourcesAttachMojo.java:
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.project.MavenProjectHelper;
+import org.codehaus.plexus.archiver.Archiver;
+import org.codehaus.plexus.archiver.ArchiverException;
+import org.codehaus.plexus.archiver.FileSet;
+import org.codehaus.plexus.archiver.util.DefaultFileSet;
+
+/**
+ * Adds the site resources (compressed in a ZIP archive) as dedicated artifact with classifier {@value #CLASSIFIER} to be installed/deployed.
+ * Usually used in combination with {@link org.apache.maven.plugins.site.descriptor.SiteDescriptorAttachMojo} to also deploy the actual site descriptor.
+ * This is used for sites inheriting from this project
+ *
+ * @since next
+ */
+@Mojo(name = SiteResourcesAttachMojo.GOAL_NAME, defaultPhase = LifecyclePhase.PACKAGE, threadSafe = true)
+public class SiteResourcesAttachMojo extends AbstractSiteMojo {
+
+ public static final String GOAL_NAME = "attach-site-resources";
+
+ /**
+ * Directory containing the <code>site.xml</code> file and the source for hand written docs (one directory
+ * per Doxia-source-supported markup types)
+ * @see <a href="/doxia/references/index.html">Doxia Markup Languages References</a>.
+ */
+ @Parameter(defaultValue = "${basedir}/src/site")
+ protected File siteDirectory;
Review Comment:
Usually the parent‘s site is maintained separately (in a docs folder, https://github.com/apache/maven-apache-parent/tree/master/docs). There you don’t use this mojo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#discussion_r1877674277
##########
src/main/java/org/apache/maven/plugins/site/SiteResourcesAttachMojo.java:
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.project.MavenProjectHelper;
+import org.codehaus.plexus.archiver.Archiver;
+import org.codehaus.plexus.archiver.ArchiverException;
+import org.codehaus.plexus.archiver.FileSet;
+import org.codehaus.plexus.archiver.util.DefaultFileSet;
+
+/**
+ * Adds the site resources (compressed in a ZIP archive) as dedicated artifact with classifier {@value #CLASSIFIER} to be installed/deployed.
+ * Usually used in combination with {@link org.apache.maven.plugins.site.descriptor.SiteDescriptorAttachMojo} to also deploy the actual site descriptor.
+ * This is used for sites inheriting from this project
+ *
+ * @since next
+ */
+@Mojo(name = SiteResourcesAttachMojo.GOAL_NAME, defaultPhase = LifecyclePhase.PACKAGE, threadSafe = true)
+public class SiteResourcesAttachMojo extends AbstractSiteMojo {
+
+ public static final String GOAL_NAME = "attach-site-resources";
+
+ /**
+ * Directory containing the <code>site.xml</code> file and the source for hand written docs (one directory
+ * per Doxia-source-supported markup types)
+ * @see <a href="/doxia/references/index.html">Doxia Markup Languages References</a>.
+ */
+ @Parameter(defaultValue = "${basedir}/src/site")
+ protected File siteDirectory;
+
+ /**
+ * Maven ProjectHelper.
+ */
+ @Component
+ private MavenProjectHelper projectHelper;
Review Comment:
I followed the same style as for https://github.com/apache/maven-site-plugin/blob/master/src/main/java/org/apache/maven/plugins/site/descriptor/SiteDescriptorAttachMojo.java. Let's refactor all mojos in one go separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "slachiewicz (via GitHub) via issues" <is...@maven.apache.org>.
slachiewicz closed pull request #216: [MSITE-911] Add goal to archive and install/deploy site resources along
URL: https://github.com/apache/maven-site-plugin/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#discussion_r1877600680
##########
src/main/java/org/apache/maven/plugins/site/SiteResourcesAttachMojo.java:
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.project.MavenProjectHelper;
+import org.codehaus.plexus.archiver.Archiver;
+import org.codehaus.plexus.archiver.ArchiverException;
+import org.codehaus.plexus.archiver.FileSet;
+import org.codehaus.plexus.archiver.util.DefaultFileSet;
+
+/**
+ * Adds the site resources (compressed in a ZIP archive) as dedicated artifact with classifier {@value #CLASSIFIER} to be installed/deployed.
+ * Usually used in combination with {@link org.apache.maven.plugins.site.descriptor.SiteDescriptorAttachMojo} to also deploy the actual site descriptor.
+ * This is used for sites inheriting from this project
+ *
+ * @since next
+ */
+@Mojo(name = SiteResourcesAttachMojo.GOAL_NAME, defaultPhase = LifecyclePhase.PACKAGE, threadSafe = true)
+public class SiteResourcesAttachMojo extends AbstractSiteMojo {
+
+ public static final String GOAL_NAME = "attach-site-resources";
+
+ /**
+ * Directory containing the <code>site.xml</code> file and the source for hand written docs (one directory
+ * per Doxia-source-supported markup types)
+ * @see <a href="/doxia/references/index.html">Doxia Markup Languages References</a>.
+ */
+ @Parameter(defaultValue = "${basedir}/src/site")
+ protected File siteDirectory;
+
+ /**
+ * Maven ProjectHelper.
+ */
+ @Component
+ private MavenProjectHelper projectHelper;
Review Comment:
Can be injected by constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#discussion_r1877603556
##########
src/main/java/org/apache/maven/plugins/site/SiteResourcesAttachMojo.java:
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.project.MavenProjectHelper;
+import org.codehaus.plexus.archiver.Archiver;
+import org.codehaus.plexus.archiver.ArchiverException;
+import org.codehaus.plexus.archiver.FileSet;
+import org.codehaus.plexus.archiver.util.DefaultFileSet;
+
+/**
+ * Adds the site resources (compressed in a ZIP archive) as dedicated artifact with classifier {@value #CLASSIFIER} to be installed/deployed.
+ * Usually used in combination with {@link org.apache.maven.plugins.site.descriptor.SiteDescriptorAttachMojo} to also deploy the actual site descriptor.
+ * This is used for sites inheriting from this project
+ *
+ * @since next
+ */
+@Mojo(name = SiteResourcesAttachMojo.GOAL_NAME, defaultPhase = LifecyclePhase.PACKAGE, threadSafe = true)
+public class SiteResourcesAttachMojo extends AbstractSiteMojo {
+
+ public static final String GOAL_NAME = "attach-site-resources";
+
+ /**
+ * Directory containing the <code>site.xml</code> file and the source for hand written docs (one directory
+ * per Doxia-source-supported markup types)
+ * @see <a href="/doxia/references/index.html">Doxia Markup Languages References</a>.
+ */
+ @Parameter(defaultValue = "${basedir}/src/site")
+ protected File siteDirectory;
+
+ /**
+ * Maven ProjectHelper.
+ */
+ @Component
+ private MavenProjectHelper projectHelper;
+
+ @Component(hint = ARCHIVE_EXTENSION)
+ private Archiver zipArchiver;
+
+ /**
+ * The file name patterns to exclude (potentially in addition to the default ones mentioned at {@link #addDefaultExcludes}).
+ * The format of each pattern is described in {@link org.codehaus.plexus.util.DirectoryScanner}.
+ * The comparison is performed against the file path relative to the {@link #siteDirectory}.
+ * <p>
+ * Each value is either a regex pattern if enclosed within {@code %regex[} and {@code ]}, otherwise an
+ * <a href="https://ant.apache.org/manual/dirtasks.html#patterns">Ant pattern</a>.
+ * Exclusions take precedence over inclusions via {@link #includes}.
+ */
+ @Parameter(defaultValue = "**/.gitignore,**/.gitattributes", required = true)
Review Comment:
default excludes covers it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#discussion_r1877613715
##########
src/main/java/org/apache/maven/plugins/site/SiteResourcesAttachMojo.java:
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.project.MavenProjectHelper;
+import org.codehaus.plexus.archiver.Archiver;
+import org.codehaus.plexus.archiver.ArchiverException;
+import org.codehaus.plexus.archiver.FileSet;
+import org.codehaus.plexus.archiver.util.DefaultFileSet;
+
+/**
+ * Adds the site resources (compressed in a ZIP archive) as dedicated artifact with classifier {@value #CLASSIFIER} to be installed/deployed.
+ * Usually used in combination with {@link org.apache.maven.plugins.site.descriptor.SiteDescriptorAttachMojo} to also deploy the actual site descriptor.
+ * This is used for sites inheriting from this project
+ *
+ * @since next
+ */
+@Mojo(name = SiteResourcesAttachMojo.GOAL_NAME, defaultPhase = LifecyclePhase.PACKAGE, threadSafe = true)
+public class SiteResourcesAttachMojo extends AbstractSiteMojo {
+
+ public static final String GOAL_NAME = "attach-site-resources";
+
+ /**
+ * Directory containing the <code>site.xml</code> file and the source for hand written docs (one directory
+ * per Doxia-source-supported markup types)
+ * @see <a href="/doxia/references/index.html">Doxia Markup Languages References</a>.
+ */
+ @Parameter(defaultValue = "${basedir}/src/site")
+ protected File siteDirectory;
Review Comment:
We also include all parent site documentation in resource .... it is what we need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSITE-911] Add goal to archive and install/deploy site resources along [maven-site-plugin]
Posted by "slachiewicz (via GitHub) via issues" <is...@maven.apache.org>.
slachiewicz commented on PR #216:
URL: https://github.com/apache/maven-site-plugin/pull/216#issuecomment-6626561661
@kwin, is this still something you want to land? Development of the 4.0.0-M line has stopped and master is the 3.x line again, so this branch now shows about 100 old 4.0.0-M commits on top of your change. If you're still interested, it would need to be rebased onto current master and adjusted to 3.x (Doxia 2.2 and Sitetools 2.2 are already there). I'm happy to carry it over from a new branch with your commits kept as authored, if you'd rather not do the rebase yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org