You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/02/26 15:53:33 UTC
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/4791
SPARK-4545 [STREAMING] [WIP] If first Spark Streaming batch fails, it waits 10x batch duration before stopping
Consider failed jobs completed too, to avoid excessive waiting dur...ing shutdown for jobs that will never succeed
@tdas I may need your help on this. You can see some more detail in the JIRA (https://issues.apache.org/jira/browse/SPARK-4545). Basically, if an error occurs in a streaming job and the initial job fails, and will never complete, and the `StreamingContext` is stopped, then it will wait a long time (10x batch duration by default) for all jobs to finish, when it's already known that this job failed.
I do not know whether this is a valid fix, but wanted to propose this for a look. Basically: should failed jobs also be considered completed?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-4545
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4791.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4791
----
commit e3b4f5162d0bdbe5dd12716a86adc54a1e98292a
Author: Sean Owen <so...@cloudera.com>
Date: 2015-02-26T14:51:01Z
(WIP) Consider failed jobs completed too, to avoid excessive waiting during shutdown for jobs that will never succeed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4791#issuecomment-76191852
[Test build #28005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28005/consoleFull) for PR 4791 at commit [`e3b4f51`](https://github.com/apache/spark/commit/e3b4f5162d0bdbe5dd12716a86adc54a1e98292a).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4791#issuecomment-76207169
[Test build #28005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28005/consoleFull) for PR 4791 at commit [`e3b4f51`](https://github.com/apache/spark/commit/e3b4f5162d0bdbe5dd12716a86adc54a1e98292a).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
Posted by srowen <gi...@git.apache.org>.
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/4791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4791#issuecomment-76480622
Interesting idea! Let me finish up the Spark 1.3 stuff and then lets discuss this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4791#issuecomment-78654578
I'm gonna close this since I doubt it's going to be the basis of any correct fix, but am still interested in how to address this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4545 [STREAMING] [WIP] If first Spark St...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4791#issuecomment-76207186
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28005/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org