You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/11 09:09:19 UTC
[GitHub] [activemq-artemis] ehsavoie commented on a change in pull request #3448: [ARTEMIS-3113]: Artemis AMQP shouldn't depend on JMS.
ehsavoie commented on a change in pull request #3448:
URL: https://github.com/apache/activemq-artemis/pull/3448#discussion_r574341154
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java
##########
@@ -264,8 +266,8 @@ protected static ServerJMSMessage processHeader(ServerJMSMessage jms, Header hea
jms.setLongProperty("JMSXDeliveryCount", header.getDeliveryCount().longValue() + 1);
}
} else {
- jms.setJMSPriority((byte) javax.jms.Message.DEFAULT_PRIORITY);
- jms.setJMSDeliveryMode(DeliveryMode.NON_PERSISTENT);
+ jms.setJMSPriority((byte) MESSAGE_DEFAULT_PRIORITY);
Review comment:
I'm not sure that we should use JMS or Jakarta Messaging API to convert between core and amqp messsages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org