You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jkbkupczyk (via GitHub)" <gi...@apache.org> on 2023/06/22 16:35:00 UTC
[GitHub] [commons-net] jkbkupczyk opened a new pull request, #157: Net constants refine
jkbkupczyk opened a new pull request, #157:
URL: https://github.com/apache/commons-net/pull/157
- Makes `org.apache.commons.net.util.NetConstants` `final` to prevent inheritance (utility class)
- Renames `org.apache.commons.net.util.NetConstants::EMPTY_BTYE_ARRAY` to `org.apache.commons.net.util.NetConstants::EMPTY_BYTE_ARRAY`
FYI @garydgregory @kinow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory closed pull request #157: Net constants refine
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #157: Net constants refine
URL: https://github.com/apache/commons-net/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #157: Net constants refine
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #157:
URL: https://github.com/apache/commons-net/pull/157#issuecomment-1603357184
-1 unfortunately, this will have to wait until 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #157: Net constants refine
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-net/pull/157#discussion_r1268661489
##########
src/main/java/org/apache/commons/net/util/NetConstants.java:
##########
@@ -23,7 +23,7 @@
*
* @since 3.8.0
*/
-public class NetConstants {
+public final class NetConstants {
Review Comment:
@jkbkupczyk
You can't make this class final as it will break binary compatibility (it is public).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #157: Net constants refine
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #157:
URL: https://github.com/apache/commons-net/pull/157#issuecomment-1642906041
Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org