[jira] [Commented] (PHOENIX-2005) Connection utilities omit zk client port, parent znode

["Nick Dimiduk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556697#comment-14556697 ] 

Nick Dimiduk commented on PHOENIX-2005:
---------------------------------------

Bringing over review comments from PHOENIX-1980.

[~enis]
{quote}
getUrl() changes looks right. QueryUtil.getConnectionUrl() now does the right thing.
bq. + logger.info("Found quorum: " + quorum + ":" + znode);
Maybe debug. No biggie.
bq. + if (cmdLine.hasOption(ZK_QUORUM_OPT.getOpt())) {
Previously -z meant that you can only pass the zookeeper quorum (not port and znode parent from my understanding). If that is not the case, this logic seems correct. If that is the case, then why don't we still do the same thing by just setting the conf value and let the QueryUtil.getConnectionUrl() deal with constructing the JDBC string?

For the remove tests, maybe we can add a simple test for QueryUtil.getConnectionUrl() checking for all quorum, port and znode parent.
{quote}

> Connection utilities omit zk client port, parent znode
> ------------------------------------------------------
>
>                 Key: PHOENIX-2005
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2005
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>
> Our config parsing utilities assume the zookeeper quorum server list is sufficient for connecting to HBase. This not the case and should not be assumed; take into account client port and znode parent. See conversation over on PHOENIX-1980.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)