You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2015/10/08 14:27:29 UTC
Review Request 39129: Views: HDFS API utility needs to work with WASB
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39129/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13345
https://issues.apache.org/jira/browse/AMBARI-13345
Repository: ambari
Description
-------
Changes in HdfsApi for wasb support
Diffs
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 6718093
contrib/views/utils/pom.xml f930061
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java d992c2e
Diff: https://reviews.apache.org/r/39129/diff/
Testing
-------
Manual Testing Done.
Deployed file view to cluster with wasb. File view is working properly after patch.
Thanks,
Gaurav Nagar
Re: Review Request 39129: Views: HDFS API utility needs to work with
WASB
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39129/#review101911
-----------------------------------------------------------
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java (line 92)
<https://reviews.apache.org/r/39129/#comment159412>
This should be a check where the defaultFS starts with hdfs. There are other HCFS in addition to wasb such as glusterfs, viprfs, etc.
- Sumit Mohanty
On Oct. 8, 2015, 12:27 p.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39129/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 12:27 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13345
> https://issues.apache.org/jira/browse/AMBARI-13345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changes in HdfsApi for wasb support
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 6718093
> contrib/views/utils/pom.xml f930061
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java d992c2e
>
> Diff: https://reviews.apache.org/r/39129/diff/
>
>
> Testing
> -------
>
> Manual Testing Done.
> Deployed file view to cluster with wasb. File view is working properly after patch.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 39129: Views: HDFS API utility needs to work with
WASB
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39129/#review102491
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 9, 2015, 9:30 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39129/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 9:30 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13345
> https://issues.apache.org/jira/browse/AMBARI-13345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changes in HdfsApi for wasb support
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 6718093
> contrib/views/utils/pom.xml f930061
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java d992c2e
>
> Diff: https://reviews.apache.org/r/39129/diff/
>
>
> Testing
> -------
>
> Manual Testing Done.
> Deployed file view to cluster with wasb. File view is working properly after patch.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 39129: Views: HDFS API utility needs to work with
WASB
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39129/#review102448
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Oct. 9, 2015, 9:30 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39129/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 9:30 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13345
> https://issues.apache.org/jira/browse/AMBARI-13345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changes in HdfsApi for wasb support
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 6718093
> contrib/views/utils/pom.xml f930061
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java d992c2e
>
> Diff: https://reviews.apache.org/r/39129/diff/
>
>
> Testing
> -------
>
> Manual Testing Done.
> Deployed file view to cluster with wasb. File view is working properly after patch.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 39129: Views: HDFS API utility needs to work with
WASB
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39129/
-----------------------------------------------------------
(Updated Oct. 9, 2015, 9:30 a.m.)
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Changes
-------
Updated patch as suggested in comment.
Bugs: AMBARI-13345
https://issues.apache.org/jira/browse/AMBARI-13345
Repository: ambari
Description
-------
Changes in HdfsApi for wasb support
Diffs (updated)
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 6718093
contrib/views/utils/pom.xml f930061
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java d992c2e
Diff: https://reviews.apache.org/r/39129/diff/
Testing
-------
Manual Testing Done.
Deployed file view to cluster with wasb. File view is working properly after patch.
Thanks,
Gaurav Nagar