You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "Ron Grabowski (JIRA)" <ji...@apache.org> on 2007/12/31 17:30:43 UTC
[jira] Commented: (LOG4NET-88) [PATCH] to AdoNetAppender.cs to
support .NET 2.0 connectionStrings configuration section
[ https://issues.apache.org/jira/browse/LOG4NET-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12555113 ]
Ron Grabowski commented on LOG4NET-88:
--------------------------------------
Fixed in r607748.
I couldn't use Phil's patch because he didn't check the correct radio button that grants us permission to use his code.
> [PATCH] to AdoNetAppender.cs to support .NET 2.0 connectionStrings configuration section
> ----------------------------------------------------------------------------------------
>
> Key: LOG4NET-88
> URL: https://issues.apache.org/jira/browse/LOG4NET-88
> Project: Log4net
> Issue Type: Improvement
> Components: Appenders
> Affects Versions: 1.2.10
> Environment: Windows XP .NET 2.0
> Reporter: Haacked
> Assignee: Ron Grabowski
> Attachments: AdoNetAppenderConnectionStringName.patch
>
>
> This is a patch for [LOG4NET-78] https://issues.apache.org/jira/browse/LOG4NET-78. This adds a new "connectionStringName" attribute (and corresponding ConnectionStringName) property to the AdoNetAppender class. This is a reference to a connection string within the <ConnectionStrings> section of an App.config or Web.config file.
> The choice of name "connectionStringName" is consistent with the naming that Microsoft uses in the various Providers such as SqlMembershipProvider.
> I made sure to put this code in between #if NET_2_0 blocks. However, the patch does not include the required change to the log4net.csproj file which needs to reference the System.Configuration.dll (C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.configuration.dll) assembly.
> This is a .NET 2.0 only assembly so I was unsure how to add a conditional compilation element so that the project reference would not break log4net for .NET 1.0 and .NET 1.1.
> If there is a better way to do so, please let me know!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.