[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6960: create parameter to determine whether roles are public or private

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#discussion_r1051989828


##########
api/src/main/java/org/apache/cloudstack/api/command/admin/acl/ListRolesCmd.java:
##########
@@ -110,7 +111,7 @@ private void setupResponse(final Pair<List<Role>, Integer> roles) {
     public void execute() {
         Pair<List<Role>, Integer> roles;
         if (getId() != null && getId() > 0L) {
-            roles = new Pair<List<Role>, Integer>(Collections.singletonList(roleService.findRole(getId())), 1);
+            roles = new Pair<List<Role>, Integer>(Collections.singletonList(roleService.findRole(getId(), true)), 1);

Review Comment:
   ```suggestion
               roles = new Pair<>(Collections.singletonList(roleService.findRole(getId(), true)), 1);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org