You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/05/03 05:24:54 UTC
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10290
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
[jepsen] make kudu-master-see-tservers more robust
Updated kudu-master-see-tservers function to be less fragile.
The prior implementation depended on the format of the output of the
'kudu cluster ksck' sub-command. The updated implementation uses
'kudu tserver list' and relies only on the number of output lines
by the latter sub-command.
Also, dropped redundant 'node' parameter of the kudu-cli function.
Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
1 file changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/10290/1
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10290 )
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10290/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj:
http://gerrit.cloudera.org:8080/#/c/10290/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj@146
PS1, Line 146: is
> While you're here, delete this extra 'is'.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 03 May 2018 15:21:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10290 )
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
[jepsen] make kudu-master-see-tservers more robust
Updated kudu-master-see-tservers function to be less fragile.
The prior implementation depended on the format of the output of the
'kudu cluster ksck' sub-command. The updated implementation uses
'kudu tserver list' and relies only on the number of output lines
by the latter sub-command.
Also, dropped redundant 'node' parameter of the kudu-cli function.
Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Reviewed-on: http://gerrit.cloudera.org:8080/10290
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10290 )
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
Patch Set 2: Verified+1
Unrelated dist-test failure:
failed to download task files: WARNING 102 isolateserver(1484): Adding unknown file be1c45bc2f9
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 03 May 2018 16:11:47 +0000
Gerrit-HasComments: No
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10290 )
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Do extra nit if you want.
http://gerrit.cloudera.org:8080/#/c/10290/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj:
http://gerrit.cloudera.org:8080/#/c/10290/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj@146
PS1, Line 146: is
While you're here, delete this extra 'is'.
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 03 May 2018 05:44:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10290 )
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10290 )
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 03 May 2018 15:24:00 +0000
Gerrit-HasComments: No
[kudu-CR] [jepsen] make kudu-master-see-tservers more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10290
to look at the new patch set (#2).
Change subject: [jepsen] make kudu-master-see-tservers more robust
......................................................................
[jepsen] make kudu-master-see-tservers more robust
Updated kudu-master-see-tservers function to be less fragile.
The prior implementation depended on the format of the output of the
'kudu cluster ksck' sub-command. The updated implementation uses
'kudu tserver list' and relies only on the number of output lines
by the latter sub-command.
Also, dropped redundant 'node' parameter of the kudu-cli function.
Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
1 file changed, 11 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/10290/2
--
To view, visit http://gerrit.cloudera.org:8080/10290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8b9ff0b7c145e5235a94de27bbedea1fe36f5e60
Gerrit-Change-Number: 10290
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>