[GitHub] [airflow] ashb commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#discussion_r333399804
 
 

 ##########
 File path: tests/serialization/test_dag_serialization.py
 ##########
 @@ -67,14 +69,49 @@
                 "ui_color": "#fff",
                 "ui_fgcolor": "#000",
                 "template_fields": [],
+                "extra_links": [],
                 "_task_type": "BaseOperator",
             },
+            "custom_task": {
+                "task_id": "custom_task",
+                "retries": 1,
+                "retry_delay": 300.0,
+                "_downstream_task_ids": [],
+                "_inlets": {
+                    "auto": False, "task_ids": [], "datasets": []
+                },
+                "_outlets": {"datasets": []},
+                "ui_color": "#fff",
+                "ui_fgcolor": "#000",
+                "template_fields": [],
+                "extra_links": ["github"],
 
 Review comment:
   I'm not sure the Link name is unique enough -- Given the `link.name` attribute is what is displayed in the UI it is entirely reasonable for two different link classes to define a link with a name of "Logs" or "View in AWS" but that have different implementations.
   
   I think `<plugin_name>.<LinkClass>` would be better, so `test_plugin.GithubLink`.
   
   (To make this work we'd likely need to change a bit how we store plugins in airflow.plugins_manager)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services