You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@deltaspike.apache.org by st...@apache.org on 2017/12/20 20:57:48 UTC

deltaspike git commit: DELTASPIKE-1307 escape windowId

Repository: deltaspike
Updated Branches:
  refs/heads/master 150924773 -> 4e2502358


DELTASPIKE-1307 escape windowId

txs to md for the catch!


Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo
Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/4e250235
Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/4e250235
Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/4e250235

Branch: refs/heads/master
Commit: 4e2502358526b944fc5514c206d306e97ff271bb
Parents: 1509247
Author: Mark Struberg <st...@apache.org>
Authored: Wed Dec 20 21:53:10 2017 +0100
Committer: Mark Struberg <st...@apache.org>
Committed: Wed Dec 20 21:53:10 2017 +0100

----------------------------------------------------------------------
 .../jsf/impl/component/window/WindowIdHtmlRenderer.java          | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/deltaspike/blob/4e250235/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java
----------------------------------------------------------------------
diff --git a/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java b/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java
index ed2752d..b0f3175 100644
--- a/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java
+++ b/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/component/window/WindowIdHtmlRenderer.java
@@ -77,7 +77,9 @@ public class WindowIdHtmlRenderer extends Renderer
         ResponseWriter writer = context.getResponseWriter();
         writer.write("<script type=\"text/javascript\">");
         writer.write("(function(){");
-        writer.write("dswh.init('" + windowId + "','"
+        writer.write("dswh.init('");
+        writer.writeText(windowId, null);
+        writer.write("','"
                 + clientWindowRenderMode.name() + "',"
                 + maxWindowIdLength + ",{");