You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/28 02:37:14 UTC

Review Request: Removed the unnecessary Future argument to Slave::doReliableRegistration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10160/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

This was a bit of cleanup before creating the fix for MESOS-305.


Diffs
-----

  src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
  src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 

Diff: https://reviews.apache.org/r/10160/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request: Removed the unnecessary Future argument to Slave::doReliableRegistration.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10160/#review18454
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 28, 2013, 1:37 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10160/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 1:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This was a bit of cleanup before creating the fix for MESOS-305.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
>   src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 
> 
> Diff: https://reviews.apache.org/r/10160/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request: Removed the unnecessary Future argument to Slave::doReliableRegistration.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10160/
-----------------------------------------------------------

(Updated April 16, 2013, 12:39 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased, no need for review.


Description
-------

This was a bit of cleanup before creating the fix for MESOS-305.


Diffs (updated)
-----

  src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
  src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa 

Diff: https://reviews.apache.org/r/10160/diff/


Testing
-------

make check


Thanks,

Ben Mahler