[GitHub] [ratis] SzyWilliam commented on a diff in pull request #798: RATIS-1759. Support client use linearizable read per request

[GitBox <gi...@apache.org>]

SzyWilliam commented on code in PR #798:
URL: https://github.com/apache/ratis/pull/798#discussion_r1051395751


##########
ratis-client/src/main/java/org/apache/ratis/client/api/BlockingApi.java:
##########
@@ -45,14 +45,19 @@ default RaftClientReply sendReadOnly(Message message) throws IOException {
     return sendReadOnly(message, null);
   }
 
+  default RaftClientReply sendReadOnly(Message message, RaftPeerId server) throws IOException {
+    return sendReadOnly(message, server, false);
+  }
+
   /**
    * Send the given readonly message to the raft service.
    *
    * @param message The request message.
    * @param server The target server.  When server == null, send the message to the leader.
+   * @param readIndex weather use linearizable read.
    * @return the reply.
    */
-  RaftClientReply sendReadOnly(Message message, RaftPeerId server) throws IOException;
+  RaftClientReply sendReadOnly(Message message, RaftPeerId server, boolean readIndex) throws IOException;

Review Comment:
   Shall we use `Read.Option` as the third parameter? We may introduce lease-based linearizable read in the future, and boolean won't work then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org