You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/14 15:14:23 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2203: LUCENE-9665 Hunspell: support default encoding
donnerpeter opened a new pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Support aff files that don't have `SET encoding` directive
# Solution
Copy the logic from hunspell C++
# Tests
Added
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2203: LUCENE-9665: Hunspell: support default encoding
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203#issuecomment-760764447
Thanks Peter. Yes, you can close the Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2203: LUCENE-9665: Hunspell: support default encoding
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2203: LUCENE-9665: Hunspell: support default encoding
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203#discussion_r557667155
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -98,6 +98,7 @@
// TODO: really for suffixes we should reverse the automaton and run them backwards
private static final String PREFIX_CONDITION_REGEX_PATTERN = "%s.*";
private static final String SUFFIX_CONDITION_REGEX_PATTERN = ".*%s";
+ static final String DEFAULT_ENCODING = "ISO8859-1";
Review comment:
This should reference a constant in StandardCharsets (and get the name from there).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2203: LUCENE-9665: Hunspell: support default encoding
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203#issuecomment-760761586
Thanks! Should I close the JIRA issue, or there's some other workflow for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on pull request #2203: LUCENE-9665: Hunspell: support default encoding
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203#issuecomment-760469229
> I trust this is indeed how it works? :)
Quoting the JIRA issue:
> From https://github.com/hunspell/hunspell/blob/master/src/hunspell/affixmgr.cxx#L3519 and https://github.com/hunspell/hunspell/blob/master/src/hunspell/csutil.hxx#L97. Needed, for example, for easier migration of Hunspell's own unit tests https://github.com/hunspell/hunspell/tree/master/tests (most of which lack SET directive) to Lucene.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2203: LUCENE-9665: Hunspell: support default encoding
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2203:
URL: https://github.com/apache/lucene-solr/pull/2203#issuecomment-760474441
Thanks Peter. Please add lucene/CHANGES.txt entry, attributed to yourself. Then I'll merge it in. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org