You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2018/10/11 09:55:42 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #2607: remove serviceclassHolder and also fix the issue #2637

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=h1) Report
> Merging [#2607](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/79ea2acba862ed31dec2615220e0accac49c3dfb?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `60%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2607      +/-   ##
============================================
- Coverage     47.53%   47.53%   -0.01%     
+ Complexity     4303     4302       -1     
============================================
  Files           557      556       -1     
  Lines         24433    24401      -32     
  Branches       4349     4327      -22     
============================================
- Hits          11615    11598      -17     
+ Misses        11021    11000      -21     
- Partials       1797     1803       +6
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `48.37% <100%> (ø)` | `64 <0> (ø)` | :arrow_down: |
| [.../alibaba/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL3Jlc3QvUmVzdFByb3RvY29sLmphdmE=) | `64.75% <100%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...va/com/alibaba/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0NvbmZpZ1V0aWxzLmphdmE=) | `71.42% <33.33%> (-0.3%)` | `45 <1> (+1)` | |
| [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3N0YXR1cy9zdXBwb3J0L0xvYWRTdGF0dXNDaGVja2VyLmphdmE=) | `50% <0%> (-10%)` | `2% <0%> (ø)` | |
| [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `80% <0%> (-7.5%)` | `3% <0%> (ø)` | |
| [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `83.33% <0%> (-5.56%)` | `3% <0%> (ø)` | |
| [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `85.71% <0%> (-4.29%)` | `3% <0%> (ø)` | |
| [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [...a/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNsaWVudC5qYXZh) | `64.4% <0%> (-3.39%)` | `11% <0%> (-1%)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2607/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=footer). Last update [79ea2ac...99bb5ba](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2607 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org