You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/11 06:38:59 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28187:
[SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after
BlockManagerMaster stops
dongjoon-hyun commented on a change in pull request #28187: [SPARK-31422][CORE] Fix NPE when BlockManagerSource is used after BlockManagerMaster stops
URL: https://github.com/apache/spark/pull/28187#discussion_r407026183
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
##########
@@ -167,10 +167,12 @@ class BlockManagerMaster(
* amount of remaining memory.
*/
def getMemoryStatus: Map[BlockManagerId, (Long, Long)] = {
+ if (driverEndpoint == null) return Map.empty
Review comment:
Although only `getStorageStatus` is used, I added the preventive code into `getMemoryStatus` together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org