You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/10 07:58:16 UTC

[GitHub] [incubator-seatunnel] qianmoQ opened a new pull request, #2393: [Feature][Connector-V1] Support unauthorized ClickHouse

qianmoQ opened a new pull request, #2393:
URL: https://github.com/apache/incubator-seatunnel/pull/2393

   ## Purpose of this pull request
   
   Support ingesting data to ClickHouse without using account password...
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2393: [Feature][Connector-V1 & V2] Support unauthorized ClickHouse

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2393:
URL: https://github.com/apache/incubator-seatunnel/pull/2393#discussion_r943220791


##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSink.java:
##########
@@ -78,7 +78,14 @@ public String getPluginName() {
     @SuppressWarnings("checkstyle:MagicNumber")
     @Override
     public void prepare(Config config) throws PrepareFailException {
-        CheckResult result = CheckConfigUtil.checkAllExists(config, HOST, DATABASE, TABLE, USERNAME, PASSWORD);
+        CheckResult result = CheckConfigUtil.checkAllExists(config, HOST, DATABASE, TABLE);
+
+        boolean isCredential = config.hasPath(USERNAME) && config.hasPath(PASSWORD);

Review Comment:
   ```suggestion
           boolean isCredential = config.hasPath(USERNAME) || config.hasPath(PASSWORD);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2393: [Feature][Connector-V1] Support unauthorized ClickHouse

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2393:
URL: https://github.com/apache/incubator-seatunnel/pull/2393#issuecomment-1211471998

   Can you add it to connector-v2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2393: [Feature][Connector-V1 & V2] Support unauthorized ClickHouse

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2393:
URL: https://github.com/apache/incubator-seatunnel/pull/2393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] qianmoQ commented on pull request #2393: [Feature][Connector-V1] Support unauthorized ClickHouse

Posted by GitBox <gi...@apache.org>.
qianmoQ commented on PR #2393:
URL: https://github.com/apache/incubator-seatunnel/pull/2393#issuecomment-1211520304

   > Can you add it to connector-v2?
   
   Ok, I'll fit it in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org