You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/02 09:34:39 UTC
[jira] [Commented] (THRIFT-3595) Perl Bindings: Set
serialization/deserialization differs
[ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127901#comment-15127901 ]
ASF GitHub Bot commented on THRIFT-3595:
----------------------------------------
GitHub user amillerchip opened a pull request:
https://github.com/apache/thrift/pull/831
THRIFT-3595 Perl: Unify implementation of set as a hashref
https://issues.apache.org/jira/browse/THRIFT-3595
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amillerchip/thrift THRIFT-3595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit 5f0f0cf57ad8c38b0b2206813a600d700aa181ac
Author: Adam Millerchip <ad...@millerchip.net>
Date: 2016-02-02T08:27:03Z
THRIFT-3595 Perl: Unify implementation of set as a hashref
----
> Perl Bindings: Set serialization/deserialization differs
> --------------------------------------------------------
>
> Key: THRIFT-3595
> URL: https://issues.apache.org/jira/browse/THRIFT-3595
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Compiler
> Affects Versions: 0.9.1, 0.9.2, 0.9.3
> Reporter: Adam Millerchip
> Priority: Minor
>
> In the Perl bindings, a Thrift Set is dezerialized as a hashref, but the serialization code expects an arrayref. This causes the code to die when called if attempting to serialize a previously dezerialized Set.
> Additionally, it looks like there is a typo in the test that is testing this feature:
> https://github.com/apache/thrift/blob/49f4dc0cd8c87213a0f80ae1daba2d094a358ea7/test/perl/TestClient.pl#L262
> If you change that {{@$setout}} to {{@$setin}}, the test fails.
> It doesn't make much sense to implement a Set in Perl as array, because arrays allow duplicate entries and are ordered.
> I've written a change for the serialization that correctly expects a hashref (will link to shortly).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)