You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/16 09:23:46 UTC
[GitHub] [camel-kamelets] nicolaferraro opened a new pull request #6: chore: fix generated YAML and required props
nicolaferraro opened a new pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro merged pull request #6: chore: fix generated YAML and required props
Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro commented on pull request #6: chore: fix generated YAML and required props
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733631
> > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).
>
> Well, currently it should be alphabetical with required fields first... But we can think about it..
The problem is that it's a map that loses the order when unmarhsalled..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] davsclaus commented on pull request #6: chore: fix generated YAML and required props
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779737440
> > > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).
> >
> >
> > Well, currently it should be alphabetical with required fields first... But we can think about it..
>
> The problem is that it's a map that loses the order when unmarhsalled.. that's more a problem that happens e.g. on Kube, once you apply it you lose the order
ah okay A..Z is also fine, just that its the same.
We had that problem earlier in core camel where a regen would shuffle the options. So its best to have a fixed sorting in the build process
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] davsclaus commented on pull request #6: chore: fix generated YAML and required props
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779710972
btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro edited a comment on pull request #6: chore: fix generated YAML and required props
Posted by GitBox <gi...@apache.org>.
nicolaferraro edited a comment on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733631
> > btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).
>
> Well, currently it should be alphabetical with required fields first... But we can think about it..
The problem is that it's a map that loses the order when unmarhsalled.. that's more a problem that happens e.g. on Kube, once you apply it you lose the order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro commented on pull request #6: chore: fix generated YAML and required props
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #6:
URL: https://github.com/apache/camel-kamelets/pull/6#issuecomment-779733093
> btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).
Well, currently it should be alphabetical with required fields first... But we can think about it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org