[GitHub] [superset] eschutho commented on a change in pull request #14845: feat: Dynamic Form for edit DB Modal

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #14845:
URL: https://github.com/apache/superset/pull/14845#discussion_r644304460



##########
File path: superset-frontend/cypress-base/cypress/integration/database/modal.test.ts
##########
@@ -16,76 +16,76 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { DATABASE_LIST } from './helper';
+// import { DATABASE_LIST } from './helper';
+// TODO: Add new tests with the modal
+// describe('Add database', () => {
+//   beforeEach(() => {
+//     cy.login();
+//   });
 
-describe('Add database', () => {
-  beforeEach(() => {
-    cy.login();
-  });
+//   it('should keep create modal open when error', () => {

Review comment:
       you can `xit` instead of comment out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org