You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/10/01 21:34:33 UTC
[GitHub] storm pull request: STORM-1082 fix nits for properties in kafka te...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/777
STORM-1082 fix nits for properties in kafka tests
rename "request.required.acks" to "acks", delete the obsoleted "serializer.class"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1082
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/777.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #777
----
commit f2a35a38929035f5cf352d8e6bf72afe40b69358
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-10-01T19:33:10Z
STORM-1082 fix nits for properties in kafka tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1082 fix nits for properties in kafka te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/777
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1082 fix nits for properties in kafka te...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/777#issuecomment-145146770
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1082 fix nits for properties in kafka te...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/777#issuecomment-145032014
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---