You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2024/01/02 07:52:41 UTC
[PR] [Bug](fix) str_to_date "" should be null [doris]
HappenLee opened a new pull request, #29402:
URL: https://github.com/apache/doris/pull/29402
## Proposed changes
```
before：
str_to_date("","") -》 “”
after：
str_to_date("","") -》 null
```
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1873713388
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1873742749
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1873749416
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.78 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.4 seconds inserted 10000000 Rows, about 352K ops/s
storage size: 17183578513 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29402:
URL: https://github.com/apache/doris/pull/29402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1873746798
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit b342fe2d40e05eef8824a7397c8d4fb9bfd4a568, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5506 5078 5095 5078
q2 399 162 186 162
q3 1482 1214 1124 1124
q4 1071 807 833 807
q5 3188 3145 3136 3136
q6 227 145 132 132
q7 974 563 520 520
q8 2164 2252 2234 2234
q9 6691 6633 6640 6633
q10 3169 3158 3147 3147
q11 344 216 241 216
q12 385 232 242 232
q13 4405 3671 3658 3658
q14 249 216 224 216
q15 605 547 547 547
q16 448 391 421 391
q17 1040 529 555 529
q18 7088 6739 6734 6734
q19 1645 1532 1447 1447
q20 572 323 341 323
q21 2832 2474 2425 2425
q22 403 338 339 338
Total cold run time: 44887 ms
Total hot run time: 40029 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5126 5029 5030 5029
q2 336 251 265 251
q3 3403 3366 3299 3299
q4 2152 2017 2031 2017
q5 5977 5888 5935 5888
q6 233 131 127 127
q7 2393 1962 1883 1883
q8 3561 3642 3643 3642
q9 9083 8992 8995 8992
q10 3884 3936 3923 3923
q11 615 480 481 480
q12 800 689 618 618
q13 3868 3194 3224 3194
q14 293 269 265 265
q15 608 557 553 553
q16 565 528 534 528
q17 2044 1823 1777 1777
q18 8742 8355 8409 8355
q19 1734 1694 1701 1694
q20 2282 2021 1992 1992
q21 5769 5395 5304 5304
q22 566 506 466 466
Total cold run time: 64034 ms
Total hot run time: 60277 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1873708926
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1873742412
TeamCity be ut coverage result:
Function Coverage: 36.64% (8615/23513)
Line Coverage: 28.69% (70013/244019)
Region Coverage: 27.67% (36231/130938)
Branch Coverage: 24.37% (18515/75970)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b342fe2d40e05eef8824a7397c8d4fb9bfd4a568_b342fe2d40e05eef8824a7397c8d4fb9bfd4a568/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) str_to_date "" should be null [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29402:
URL: https://github.com/apache/doris/pull/29402#issuecomment-1874689767
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org