You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/08/22 16:35:09 UTC

[GitHub] dangogh commented on a change in pull request #2739: Traffic Monitor formatting - go fmt

dangogh commented on a change in pull request #2739: Traffic Monitor formatting - go fmt
URL: https://github.com/apache/trafficcontrol/pull/2739#discussion_r212024087
 
 

 ##########
 File path: traffic_monitor/threadsafe/cacheavailablestatus.go
 ##########
 @@ -20,8 +20,8 @@ package threadsafe
  */
 
 import (
-	"github.com/apache/trafficcontrol/traffic_monitor/cache"
 	"github.com/apache/trafficcontrol/lib/go-tc"
+	"github.com/apache/trafficcontrol/traffic_monitor/cache"
 	"sync"
 )
 
 Review comment:
   since we're reordering anyway,  can you move the "sync" to the top with a blank line after it?  go fmt will keep the std library separate from the rest that way -- same with the file below..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services