You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Benedikt Krupp (JIRA)" <ji...@apache.org> on 2016/04/21 20:30:25 UTC
[jira] [Created] (SSHD-663) Wrong if criteria in
org.apache.sshd.common.file.util.ImmutableList.subList()
Benedikt Krupp created SSHD-663:
-----------------------------------
Summary: Wrong if criteria in org.apache.sshd.common.file.util.ImmutableList.subList()
Key: SSHD-663
URL: https://issues.apache.org/jira/browse/SSHD-663
Project: MINA SSHD
Issue Type: Bug
Affects Versions: 1.2.0, 1.1.1, 1.1.0
Reporter: Benedikt Krupp
Priority: Minor
I do not know whether 1.3.0 is affected.
in org.apache.sshd.common.file.util.ImmutableList.subList() the if criteria is wrong:
wrong code:
@Override
public ImmutableList<T> subList(int fromIndex, int toIndex) {
if (fromIndex == from && toIndex == to) {
return this;
}
return new ImmutableList<>(data, from + fromIndex, from + toIndex);
}
should be:
@Override
public ImmutableList<T> subList(int fromIndex, int toIndex) {
if (from == 0 && from+toIndex == to) {
return this;
}
return new ImmutableList<>(data, from + fromIndex, from + toIndex);
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)