You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/07/27 05:20:02 UTC
Review Request 36835: Update the util to manage the log entity for
audit log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36835/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun and shen guoquan.
Repository: sentry
Description
-------
Update the util to manage the log entity for audit log
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 3ad46c4
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactory.java 199f7f5
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactoryGM.java PRE-CREATION
Diff: https://reviews.apache.org/r/36835/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 36835: Update the util to manage the log entity
for audit log
Posted by Colin Ma <ju...@intel.com>.
> On Aug. 10, 2015, 1:28 a.m., Dapeng Sun wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java, line 67
> > <https://reviews.apache.org/r/36835/diff/1/?file=1022158#file1022158line67>
> >
> > We should update it to DBAuditMetadataLogEntity
You're right, I'll update this.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36835/#review94690
-----------------------------------------------------------
On July 27, 2015, 3:20 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36835/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 3:20 a.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update the util to manage the log entity for audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 3ad46c4
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactory.java 199f7f5
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactoryGM.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 36835: Update the util to manage the log entity
for audit log
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36835/#review94690
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java (line 67)
<https://reviews.apache.org/r/36835/#comment149315>
We should update it to DBAuditMetadataLogEntity
- Dapeng Sun
On 七月 27, 2015, 11:20 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36835/
> -----------------------------------------------------------
>
> (Updated 七月 27, 2015, 11:20 a.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update the util to manage the log entity for audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java 3ad46c4
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactory.java 199f7f5
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactoryGM.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>