You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ianbuss (via GitHub)" <gi...@apache.org> on 2025/03/12 09:49:42 UTC
[PR] Temporary fix to allow remote logging upload for task sdk [airflow]
ianbuss opened a new pull request, #47668:
URL: https://github.com/apache/airflow/pull/47668
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
In lieu of an expected improvement in the way remote log uploads are configured and handled in the Task SDK, this PR introduces a temporary fix for the Airflow 3 beta timeframe to allow remote log uploads to function. The current situation is that the `configure_logging` function in the Task SDK overwrites the Python logging configuration from Airflow's configured `logging_config` module. Thus, when the task supervisor attempts to perform the remote log upload there is no configured handler suitable and so uploading is skipped.
The "solution" in this PR is to temporarily re-configure Python's logging module (😬) to extract the correct handler and then put the logging configuration back. Since this happens at the end of a task's lifecycle, in a forked process the blast radius is small.
It also configures a `log_meta_dict` attribute which is expected to have TI metadata for some loggers. This is usually set in the `set_context` method of the respective handler but for reasons stated in the existing code comments we do not want to call this method as it will re-open file handles.
This PR is in no way meant to be the final implementation and will need to be replaced in due course but is a temporary expedient for the short term to "unblock" remote logging functionality.
related: #47634
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Temporary fix to allow remote logging upload for task sdk [airflow]
Posted by "ianbuss (via GitHub)" <gi...@apache.org>.
ianbuss commented on PR #47668:
URL: https://github.com/apache/airflow/pull/47668#issuecomment-2718167839
@ashb @amoghrajesh is this mergeable. The failing CI check is related to the amazon provider not being able to complile the xmlsec wheel, which is not related to my change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Temporary fix to allow remote logging upload for task sdk [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #47668:
URL: https://github.com/apache/airflow/pull/47668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Temporary fix to allow remote logging upload for task sdk [airflow]
Posted by "ianbuss (via GitHub)" <gi...@apache.org>.
ianbuss commented on PR #47668:
URL: https://github.com/apache/airflow/pull/47668#issuecomment-2718029234
> Yeah works for now as a stop gap solution
Agreed, this is not a substitute for a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Temporary fix to allow remote logging upload for task sdk [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #47668:
URL: https://github.com/apache/airflow/pull/47668#issuecomment-2718178525
Yes, that is unrelated, merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org