You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2018/10/31 19:54:06 UTC
[pulsar] branch master updated: Issue #2890: Dependencies for using
Pulsar in Storm topologies (#2893)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new e72ed35 Issue #2890: Dependencies for using Pulsar in Storm topologies (#2893)
e72ed35 is described below
commit e72ed35cc2b07e2ec39b84a23ae1819d94b152f4
Author: Sijie Guo <gu...@gmail.com>
AuthorDate: Wed Oct 31 12:53:59 2018 -0700
Issue #2890: Dependencies for using Pulsar in Storm topologies (#2893)
* Issue #2890: Dependencies for using Pulsar in Storm topologies
*Motivation*
Fixes #2890
The shading plugin used in pulsar-storm is promoting transitive dependencies
to the dependency-reduced pom, which will mix pulsar-client and pulsar-client-original
together in the classpath.
*Changes*
- disabled `promoteTransitiveDependencies` in pulsar-storm
- remove shade plugin from pulsar-flink
* don't exclude original, since pulsar-client pom will reduce the dependencies
---
pulsar-flink/pom.xml | 29 -----------------------------
pulsar-storm/pom.xml | 2 +-
2 files changed, 1 insertion(+), 30 deletions(-)
diff --git a/pulsar-flink/pom.xml b/pulsar-flink/pom.xml
index 1901089..a314b07 100644
--- a/pulsar-flink/pom.xml
+++ b/pulsar-flink/pom.xml
@@ -104,34 +104,5 @@
<filtering>true</filtering>
</resource>
</resources>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <createDependencyReducedPom>true</createDependencyReducedPom>
- <promoteTransitiveDependencies>true</promoteTransitiveDependencies>
- <artifactSet>
- <includes>
- <include>com.google.guava:guava</include>
- </includes>
- </artifactSet>
- <relocations>
- <relocation>
- <pattern>com.google</pattern>
- <shadedPattern>pulsar-flink-shade.com.google</shadedPattern>
- </relocation>
- </relocations>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
</build>
</project>
diff --git a/pulsar-storm/pom.xml b/pulsar-storm/pom.xml
index b01e3f7..a025fdf 100644
--- a/pulsar-storm/pom.xml
+++ b/pulsar-storm/pom.xml
@@ -121,7 +121,7 @@
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
- <promoteTransitiveDependencies>true</promoteTransitiveDependencies>
+ <promoteTransitiveDependencies>false</promoteTransitiveDependencies>
<artifactSet>
<includes>
<include>com.google.guava:guava</include>