[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1189: fix brpc.baidu.com not accessible

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #1189:
URL: https://github.com/apache/incubator-brpc/pull/1189#discussion_r461632988



##########
File path: test/brpc_naming_service_unittest.cpp
##########
@@ -59,32 +72,39 @@ TEST(NamingServiceTest, sanity) {
 #endif
 
     brpc::policy::DomainNamingService dns;
-    ASSERT_EQ(0, dns.GetServers("brpc.baidu.com:1234", &servers));
-    ASSERT_EQ(1u, servers.size());
+    ASSERT_EQ(0, dns.GetServers("baidu.com:1234", &servers));
+    ASSERT_EQ(2u, servers.size());

Review comment:
       这个数量以后会变么？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org