[GitHub] [maven-artifact-plugin] elharo commented on a change in pull request #7: prefer Apache Commons StringUtils

[GitBox <gi...@apache.org>]

elharo commented on a change in pull request #7:
URL: https://github.com/apache/maven-artifact-plugin/pull/7#discussion_r560906065



##########
File path: src/main/java/org/apache/maven/plugins/artifact/buildinfo/BuildinfoMojo.java
##########
@@ -350,8 +351,8 @@ private void compareWithReference( Map<Artifact, String> artifacts, File referen
                 p.println( "version=" + project.getVersion() );
                 p.println( "ok=" + ok );
                 p.println( "ko=" + ko );
-                p.println( "okFiles=\"" + StringUtils.join( okFilenames.iterator(), " " ) + '"' ); 
-                p.println( "koFiles=\"" + StringUtils.join( koFilenames.iterator(), " " ) + '"' ); 
+                p.println( "okFiles=\"" + StringUtils.join( okFilenames, " " ) + '"' ); 

Review comment:
       Notice how Commons-lang StringUtils.join supports Iterable, from Java 1.5; and maven-shared-utils StringUtils.join only supports Iterator from Java 1.2. It's a minor detail, but it does show the relative amounts of maintenance and attention these two products receive. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org