[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9386: Terminate the query after plan generation if timeout

[GitBox <gi...@apache.org>]

vvivekiyer commented on code in PR #9386:
URL: https://github.com/apache/pinot/pull/9386#discussion_r969002649


##########
pinot-core/src/main/java/org/apache/pinot/core/plan/GlobalPlanImplV0.java:
##########
@@ -49,6 +49,9 @@ public DataTable execute() {
     long startTime = System.currentTimeMillis();
     InstanceResponseOperator instanceResponseOperator = _instanceResponsePlanNode.run();
     long endTime1 = System.currentTimeMillis();
+    if (endTime1 > _instanceResponsePlanNode._queryContext.getEndTimeMs()) {
+      throw new RuntimeException("Timeout after plan generation");

Review Comment:
   Should we throw a TimeoutException?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org