[GitHub] [tvm] wrongtest commented on a change in pull request #9699: [TIR] Affine utility support iter lowerbound and diagnostics

[GitBox <gi...@apache.org>]

wrongtest commented on a change in pull request #9699:
URL: https://github.com/apache/tvm/pull/9699#discussion_r772833083



##########
File path: src/arith/iter_affine_map.cc
##########
@@ -347,11 +372,24 @@ class IterMapRewriter : public ExprMutator {
   //                                                              IterSplit(k, scale=1)),
   //                                                      extent=9)
   //                                             scale=1))
-  std::unordered_map<IterSumExpr, IterMark, IterSumHash, IterSumEqual> sum_fuse_map_;
+  // Example(2): expr = i*9 + j*2 + k, i in [0, 4) j in [0, 5) k in [0, 2)
+  //          predicate: 1 <= j*2 + k < 9
+  // Then,    flattened form = IterSum(IterSplit(i, scale=9),
+  //                                   IterSplit(j, scale=2),
+  //                                   IterSplit(k, scale=1))
+  //          normal form    = IterSum(IterSplit(i, scale=9),

Review comment:
       What if we change this example to `i*8 + j*2 + k` , `j*2 + k >= 1`?  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org