You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jim Brennan (Jira)" <ji...@apache.org> on 2020/06/02 17:11:01 UTC
[jira] [Commented] (HDFS-14960) TestBalancerWithNodeGroup should
not succeed with DFSNetworkTopology
[ https://issues.apache.org/jira/browse/HDFS-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124071#comment-17124071 ]
Jim Brennan commented on HDFS-14960:
------------------------------------
Thanks [~ayushtkn]! I've put up patch 006 to fix the assertEquals.
> TestBalancerWithNodeGroup should not succeed with DFSNetworkTopology
> --------------------------------------------------------------------
>
> Key: HDFS-14960
> URL: https://issues.apache.org/jira/browse/HDFS-14960
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.3
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HDFS-14960.001.patch, HDFS-14960.002.patch, HDFS-14960.003.patch, HDFS-14960.004.patch, HDFS-14960.005.patch, HDFS-14960.006.patch
>
>
> As reported in HDFS-14958, TestBalancerWithNodeGroup was succeeding even though it was using DFSNetworkTopology instead of NetworkTopologyWithNodeGroup.
> [~inigoiri] rightly suggested that this indicates the test is not very good - it should fail when run without NetworkTopologyWithNodeGroup.
> We should improve this test.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org