You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by sebb <se...@gmail.com> on 2013/07/16 00:58:01 UTC
Re: [32/50] git commit: Code cleanup - Maven requires Java 5+ :
Replace for and while loops by for each
On 15 July 2013 23:26, <ah...@apache.org> wrote:
> Code cleanup - Maven requires Java 5+ : Replace for and while loops by for each
>
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/d92746dc
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/d92746dc
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/d92746dc
>
> Branch: refs/heads/slf4j-logback
> Commit: d92746dc25bdce073571cf6fd8f78d6573fe75f0
> Parents: 1f84f8f
> Author: Arnaud Héritier <ah...@apache.org>
> Authored: Tue Jun 11 22:21:54 2013 +0200
> Committer: Arnaud Héritier <ah...@apache.org>
> Committed: Tue Jun 11 22:21:54 2013 +0200
>
> ----------------------------------------------------------------------
> .../maven/profiles/DefaultProfileManager.java | 12 ++---
> .../maven/profiles/ProfilesConversionUtils.java | 12 ++---
> .../DefaultModelInheritanceAssembler.java | 13 ++---
> .../StringSearchModelInterpolator.java | 50 +++++++++++---------
> .../project/path/DefaultPathTranslator.java | 4 +-
> .../usability/plugin/ExpressionDocumenter.java | 18 +++----
> .../maven/artifact/testutils/MockManager.java | 12 ++---
> .../apache/maven/project/ModelUtilsTest.java | 4 +-
> .../maven/project/ProjectClasspathTest.java | 3 +-
> .../inheritance/t04/ProjectInheritanceTest.java | 12 +++--
> .../inheritance/t05/ProjectInheritanceTest.java | 13 ++---
> .../inheritance/t07/ProjectInheritanceTest.java | 15 +++---
> .../resolver/DefaultArtifactCollectorTest.java | 12 ++---
> .../apache/maven/execution/ReactorManager.java | 8 ++--
> .../DefaultLifecycleBindingsInjector.java | 9 ++--
> .../org/apache/maven/project/MavenProject.java | 18 +++----
> .../java/DefaultJavaToolchainFactory.java | 15 +++---
> .../project/DefaultMavenProjectBuilderTest.java | 4 +-
> .../java/org/apache/maven/cli/CLIManager.java | 4 +-
> .../java/org/apache/maven/cli/MavenCli.java | 12 ++---
> 20 files changed, 120 insertions(+), 130 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/d92746dc/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
> ----------------------------------------------------------------------
> diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
> index 740c2cd..bfade80 100644
> --- a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
> +++ b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
> @@ -141,9 +141,9 @@ public class DefaultProfileManager
> */
> public void explicitlyActivate( List profileIds )
> {
> - for ( Iterator it = profileIds.iterator(); it.hasNext(); )
> + for ( Object profileId1 : profileIds )
> {
> - String profileId = (String) it.next();
> + String profileId = (String) profileId1;
>
> explicitlyActivate( profileId );
> }
If the code were updated to use Java 5 generics, the cast would disappear too:
public void explicitlyActivate( List<String> profileIds )
{
for ( String profileId : profileIds )
{
explicitlyActivate( profileId );
}
}
But maybe that is already planned.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org