You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "volosied (via GitHub)" <gi...@apache.org> on 2023/10/23 19:50:59 UTC
[PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
volosied opened a new pull request, #634:
URL: https://github.com/apache/myfaces/pull/634
https://issues.apache.org/jira/browse/MYFACES-4606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied closed pull request #634: MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements
URL: https://github.com/apache/myfaces/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1789977776
I would like to merge this if possible soon in order to get new 2.3 3.0 4.0 etc releases out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1776589782
Not needed: if (item && item.type &&
(item.type.toLowerCase() == "submit" ||
item.type.toLowerCase() == "button" )) {
The original behavior is somewhat different anyway... i just changed it somehow for the new code to cover more elements (aka every element)
Hence I never have issued a pr for the old code it does not expose the problem!
Either way we theoretically could unify the behavior for all branches, the old code and new code that would be feasible, if wanted, given this is a non standard behavior we are free here to do whatever we want!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1779816996
@werpu What do you recommend here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1795347329
Closing in favor of #638.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1785429084
@werpu Any updates? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1777937812
If I removed the code to just
```
appendIssuingItem: function (item, targetBuf) {
// if triggered by a Button send it along
if (item && item.type) {
// do not append if unselected
if ((item.type == "checkbox" || item.type == "radio")
&& !item.checked) {
return;
}
//buttons not always have a name unlike inputs
targetBuf.append(item.id || item.name, item.value);
}
},
```
then I see the form sent as an array.
Looks like it's caused by the preprocessed data also containing the issuing element?
Otherwise, with the existing checks, only true is sent:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1792006256
I have issued a pull request for 2.3-next, will also issue one for 3.0, please see:
https://github.com/apache/myfaces/pull/637
my integration tests pass, it is basically a backport from 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1791975218
Hi I will work on the issue today!
Sorry was not aware that it is so urgent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1780133338
Yes the original code only allows submits and buttons to be appended as issuing item, I guess we have to replicate the 4.x behavior into the old code might make sense to have a unified behavior, I will prepare something the next few days!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org