You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2023/11/24 09:37:41 UTC
[PR] Changing the queryFrameWork in Calcite*Tests may have sideeffects (druid)
kgyrtkirk opened a new pull request, #15428:
URL: https://github.com/apache/druid/pull/15428
* changes how its configured a bit to use an annotation instead of methods
* framework is cached - not thrown away; this makes it run a bit faster 16s vs 20s for CQT
* annotated cases which were using more merge buffers due to the fact that the framework was not reset to the default for every testcase (#15427)
Fixes #15427.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
#### Release note
<!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users.
If your change doesn't have end user impact, you can skip this section.
For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
-->
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Changing the queryFrameWork in Calcite*Tests may have sideeffects (druid)
Posted by "LakshSingla (via GitHub)" <gi...@apache.org>.
LakshSingla merged PR #15428:
URL: https://github.com/apache/druid/pull/15428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Changing the queryFrameWork in Calcite*Tests may have sideeffects (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #15428:
URL: https://github.com/apache/druid/pull/15428#issuecomment-1833637842
* regarding `minTopNThreshold`: I was doing an equiv refactor - so that it retains the old behaviour;
* if I change the limit to `2` it still runs just fine; however at execution time [this conditional](https://github.com/apache/druid/blob/7467d2c00d56793a03844252e43aaf5b631856b9/processing/src/main/java/org/apache/druid/query/topn/TopNQueryQueryToolChest.java#L631) decides to run the other branch: so although it does not affect the plan itself; it does affect the execution path choosen
* I also seen that `minTopNThreshold` can be [overriden in the `queryContext`](https://github.com/apache/druid/blob/7467d2c00d56793a03844252e43aaf5b631856b9/processing/src/main/java/org/apache/druid/query/topn/TopNQueryQueryToolChest.java#L629-L630) ; so there is not much reason to configure it at the `framework` level; but I was thinking there were whatever reasons....and I only wanted to fix this issue
* I have to say the [usage](https://github.com/apache/druid/blob/7467d2c00d56793a03844252e43aaf5b631856b9/sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java#L216-L226) `minTopNThreshold` raises my elbows quite a bit - especially because in case `mergeBufferCount` is not `0` it have no effect...
* I would rather put that change into a separate PR - it seems like it will be trivial; but in case things got out of hand... it will be better to have it separately
* I think `cannotVectorize` and `msqCompatible` are a bit different kind of settings; as they define the expected behaviour of the test; or kinda like obstacles it should be able to jump over :) do you have in mind something like: `@TestConfigX(msqCompatible = false)` ? we could probably do something like that at some point - but I'm not sure of the direct benefits of changing that right away
* fyi: `cannotVectorize` also has an unexpected feature: https://github.com/apache/druid/issues/15423 :)
> Can you add a Javadoc to this method
not sure which method :) but I've added some apidoc to `SqlTestFrameworkConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org