You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jan Loose (JIRA)" <ji...@apache.org> on 2008/10/29 18:36:44 UTC

[jira] Commented: (WICKET-1904) CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again

    [ https://issues.apache.org/jira/browse/WICKET-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643538#action_12643538 ] 

Jan Loose commented on WICKET-1904:
-----------------------------------

This code was removed ... and is necessary.

	/**
	 * CheckBox will by default always just use the boolean converter because the implementation
	 * expects that the string is can be converted to a boolean {@link Strings#isTrue(String)}
	 * 
	 * @see org.apache.wicket.Component#getConverter(java.lang.Class)
	 */
	@Override
	public <X> IConverter<X> getConverter(Class<X> type)
	{
		/*
		 * FIXME johan: why is this override here? it doesnt make any sense. if i say
		 * checkbox.getconverter(Integer.class) why is it still giving me a boolean converter???
		 */
		return (IConverter<X>)BooleanConverter.INSTANCE;
	}


> CheckBox incorrectly converts its model value when a custom Boolean converter is installed - again
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1904
>                 URL: https://issues.apache.org/jira/browse/WICKET-1904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-M4
>            Reporter: Jan Loose
>
> Hi,
> I tried the last version of wicket (built from trunk svn) and there is one old bug again:
> see https://issues.apache.org/jira/browse/WICKET-330
> There was removed the default Boolean converter ... and the bug is again active.
> Thx for fixing,
> H.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.