You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Vincent Siveton (JIRA)" <ji...@apache.org> on 2009/01/11 15:35:59 UTC

[jira] Created: (SHINDIG-838) Improve exceptions when a file doesn't exist

Improve exceptions when a file doesn't exist
--------------------------------------------

                 Key: SHINDIG-838
                 URL: https://issues.apache.org/jira/browse/SHINDIG-838
             Project: Shindig
          Issue Type: Improvement
    Affects Versions: trunk
            Reporter: Vincent Siveton


JsFeatureLoader#loadFiles() doesn't check if a file exist or not and #processFile() just catch IO errors.
IMHO It should be better to throw an exception if a file doesn't exist instead of displaying a warning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-838) Improve exceptions when a file doesn't exist

Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton updated SHINDIG-838:
------------------------------------

    Attachment: SHINDIG-838.patch

This patch throws an exception if a file doesn't exist and update test case.
Also, improve endsWith call (SHINDIG-225)

> Improve exceptions when a file doesn't exist
> --------------------------------------------
>
>                 Key: SHINDIG-838
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-838
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Vincent Siveton
>         Attachments: SHINDIG-838.patch
>
>
> JsFeatureLoader#loadFiles() doesn't check if a file exist or not and #processFile() just catch IO errors.
> IMHO It should be better to throw an exception if a file doesn't exist instead of displaying a warning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-838) Improve exceptions when a file doesn't exist

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-838.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.x-incubating
                   trunk

patch applied.

> Improve exceptions when a file doesn't exist
> --------------------------------------------
>
>                 Key: SHINDIG-838
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-838
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Vincent Siveton
>             Fix For: trunk, 1.0.x-incubating
>
>         Attachments: SHINDIG-838.patch
>
>
> JsFeatureLoader#loadFiles() doesn't check if a file exist or not and #processFile() just catch IO errors.
> IMHO It should be better to throw an exception if a file doesn't exist instead of displaying a warning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.