You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "topsli (via GitHub)" <gi...@apache.org> on 2024/12/23 08:34:58 UTC

[I] [DSIP-88][Master] Add Other_Continue FailureStrategy [dolphinscheduler]

topsli opened a new issue, #16912:
URL: https://github.com/apache/dolphinscheduler/issues/16912

   ### Search before asking
   
   - [X] I had searched in the [DSIP](https://github.com/apache/dolphinscheduler/issues/14102) and found no similar DSIP.
   
   
   ### Motivation
   
   Currently, the list of FailureStrategy only have END and CONTINUE. May be it should have another choice:c.
   
   /**
        * 0 ending process when some tasks failed.
        * 1 continue running when some tasks failed.
        * 2 just ending the relative process, the other process can continue.
        **/
   END(0, "end"),
   CONTINUE(1, "continue"),
   OTHER_CONTINUE(2, "other_continue");
   
   
   ### Design Detail
   
   _No response_
   
   ### Compatibility, Deprecation, and Migration Plan
   
   _No response_
   
   ### Test Plan
   
   _No response_
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-][Master] Add Continue_Other_Task_Chain FailureStrategy [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #16912: [DSIP-][Master] Add Continue_Other_Task_Chain FailureStrategy
URL: https://github.com/apache/dolphinscheduler/issues/16912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-][Master] Add Other_Continue FailureStrategy [dolphinscheduler]

Posted by "topsli (via GitHub)" <gi...@apache.org>.
topsli commented on issue #16912:
URL: https://github.com/apache/dolphinscheduler/issues/16912#issuecomment-2561545635

   The status of the workflow instance also is failed. 
   ![1735092189761_A8ED0534-1E0E-42a1-8516-8A7134029AC8](https://github.com/user-attachments/assets/cf4f4f28-23e5-4061-97b0-ac78930e984e)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-][Master] Add Other_Continue FailureStrategy [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on issue #16912:
URL: https://github.com/apache/dolphinscheduler/issues/16912#issuecomment-2561556380

   The current naming of our strategies is confusing
   It's better to have a more intuitive name
   e.g.
   ```
   Continue_Other_Task("One task failed will continue other running task")
   Continue_Other_Task_Chain("One task failed will continue other  running task chain")
   Kill_Other_Task_Chain("One task failed will kill other running task chain")
   ```
   
   `Continue` and `OTHER_CONTINUE` will make confuse. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-][Master] Add Other_Continue FailureStrategy [dolphinscheduler]

Posted by "topsli (via GitHub)" <gi...@apache.org>.
topsli commented on issue #16912:
URL: https://github.com/apache/dolphinscheduler/issues/16912#issuecomment-2561560586

   Continue_Other_Task_Chain("One task failed will continue other  running task chain").
   I think this one(Continue_Other_Task_Chain)is the best description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-88][Master] Add Other_Continue FailureStrategy [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on issue #16912:
URL: https://github.com/apache/dolphinscheduler/issues/16912#issuecomment-2559238771

   What is `OTHER_CONTINUE `, please add detail design and specific motivation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-][Master] Add Other_Continue FailureStrategy [dolphinscheduler]

Posted by "topsli (via GitHub)" <gi...@apache.org>.
topsli commented on issue #16912:
URL: https://github.com/apache/dolphinscheduler/issues/16912#issuecomment-2561542848

   For example, a workflow process which have three branches like A,B,C.  If branch B have a task failed, only affects the branch B. The other branch can continue to running.
   ![1735091800531_3F1ABDBD-7137-4ea8-8054-BE3BBA8A5876](https://github.com/user-attachments/assets/ebddc812-b5f3-40b4-9faa-b4247a267522)
   ![1735091773503_345302E8-292B-425b-892B-A5E3F8B83F01](https://github.com/user-attachments/assets/154f2be9-e1f7-4e4f-9cc8-4f46e0a1e376)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org