You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "lzx404243 (via GitHub)" <gi...@apache.org> on 2023/08/09 19:46:26 UTC
[GitHub] [trafficserver] lzx404243 opened a new pull request, #10167: Fixes h3 crash in accept() triggered by ip_allow rejection
lzx404243 opened a new pull request, #10167:
URL: https://github.com/apache/trafficserver/pull/10167
This fixes #10160 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] lzx404243 commented on pull request #10167: Fixed h3 crash in accept() triggered by ip_allow rejection
Posted by "lzx404243 (via GitHub)" <gi...@apache.org>.
lzx404243 commented on PR #10167:
URL: https://github.com/apache/trafficserver/pull/10167#issuecomment-1672199023
> Would you describe how the crash happens?
Good question @maskit . When calling `quiche_conn_is_established()`, `this->_quiche_con` is not a `nullptr`. It turns to a `nullptr` in `free_thread()` with the the following function call sequence:
```
#0 QUICNetVConnection::free_thread (this=0xffff24216a00, t=0x1d69e470) at QUICNetVConnection_quiche.cc:117
#1 0x0000000000d8e878 in NetHandler::free_netevent (this=0x1d6a2870, ne=0xffff24216c20) at NetHandler.cc:204
#2 0x0000000000d4dc9c in UnixNetVConnection::do_io_close (this=0xffff24216a00, alerrno=-1) at UnixNetVConnection.cc:681
#3 0x0000000000e27924 in Http3SessionAccept::mainEvent (this=0x1e92c210, event=202, data=0xffff24216a00) at Http3SessionAccept.cc:90
#4 0x00000000008aea68 in Continuation::handleEvent (this=0x1e92c210, event=202, data=0xffff24216a00)
at /home/zli11/src/h3-sni-check/iocore/eventsystem/I_Continuation.h:228
#5 0x0000000000d670fc in QUICNetVConnection::_start_application (this=0xffff24216a00) at QUICNetVConnection_quiche.cc:249
#6 0x0000000000d66f9c in QUICNetVConnection::_switch_to_established_state (this=0xffff24216a00) at QUICNetVConnection_quiche.cc:225
#7 0x0000000000d665f0 in QUICNetVConnection::state_handshake (this=0xffff24216a00, event=2500, data=0x0) at QUICNetVConnection_quiche.cc:151
```
The reason why `Http3SessionAccept::mainEvent` calls `do_io_close` is because `Http3SessionAccept::accept` returns `false`(ip_allow rejection).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #10167: Fixed h3 crash in accept() triggered by ip_allow rejection
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #10167:
URL: https://github.com/apache/trafficserver/pull/10167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #10167: Fixed h3 crash in accept() triggered by ip_allow rejection
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #10167:
URL: https://github.com/apache/trafficserver/pull/10167#issuecomment-1672242908
Ooh, I see. ip_allow rejects sessions but not connections. And there's no signaling from SessionAccept about the rejection...
Ok, I'm sold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #10167: Fixed h3 crash in accept() triggered by ip_allow rejection
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #10167:
URL: https://github.com/apache/trafficserver/pull/10167#issuecomment-1672178465
I wonder where/when `this->_quiche_con` becomes nullptr.
The backtrace says the state (the handler) of QUICNetVC changed to `state_established` in `state_handshake`. That means `quiche_conn_is_established(this->_quiche_con)` was called at the beginning of `state_handshake`. I don't think `quiche_conn_is_established` returns `true` if `this->_quiche_con` is nullptr.
Also, switching to established state where the connection is denied doesn't sound good.
Would you describe how the crash happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org