You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/06/28 10:12:29 UTC
[jira] Created: (HARMONY-686) [classlib][nio] Refactor
SocketAdapter.checkClosedAndCreate(boolean) in
o.a.h.nio.internal.SocketChannelImpl
[classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
------------------------------------------------------------------------------------------------------------
Key: HARMONY-686
URL: http://issues.apache.org/jira/browse/HARMONY-686
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
1. Unused parameter. The boolean parameter is unnecessary.
2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
3. One FIXME.
I'll upload a patch soon. Thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-686) [classlib][nio] Refactor
SocketAdapter.checkClosedAndCreate(boolean) in
o.a.h.nio.internal.SocketChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-686?page=comments#action_12418357 ]
Andrew Zhang commented on HARMONY-686:
--------------------------------------
Hello George,
The fix looks good, thanks!
Best regards,
Andrew
> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-686
> URL: http://issues.apache.org/jira/browse/HARMONY-686
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME.
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-686) [classlib][nio] Refactor
SocketAdapter.checkClosedAndCreate(boolean) in
o.a.h.nio.internal.SocketChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-686?page=all ]
George Harley closed HARMONY-686:
---------------------------------
Verified by Andrew.
> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-686
> URL: http://issues.apache.org/jira/browse/HARMONY-686
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME.
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-686) [classlib][nio] Refactor
SocketAdapter.checkClosedAndCreate(boolean) in
o.a.h.nio.internal.SocketChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-686?page=all ]
Andrew Zhang updated HARMONY-686:
---------------------------------
Attachment: nio.diff
Hello,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-686
> URL: http://issues.apache.org/jira/browse/HARMONY-686
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME.
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-686) [classlib][nio] Refactor
SocketAdapter.checkClosedAndCreate(boolean) in
o.a.h.nio.internal.SocketChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-686?page=all ]
George Harley reassigned HARMONY-686:
-------------------------------------
Assign To: George Harley
> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-686
> URL: http://issues.apache.org/jira/browse/HARMONY-686
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME.
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-686) [classlib][nio] Refactor
SocketAdapter.checkClosedAndCreate(boolean) in
o.a.h.nio.internal.SocketChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-686?page=all ]
George Harley resolved HARMONY-686:
-----------------------------------
Resolution: Fixed
Hi Andrew,
Refactorings committed in revision 417737. Please could you confirm that they have been applied as expected ?
Best regards,
George
> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-686
> URL: http://issues.apache.org/jira/browse/HARMONY-686
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME.
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira