You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/24 05:01:13 UTC
[jira] [Commented] (STORM-596) "topology.receiver.buffer.size" has
no effect
[ https://issues.apache.org/jira/browse/STORM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257928#comment-14257928 ]
ASF GitHub Bot commented on STORM-596:
--------------------------------------
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/363
STORM-596: remove config topology.receiver.buffer.size
topology.receiver.buffer.size has no effect and not necessary for now.
Should we just remove it ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #363
----
commit 97ae36e42abc961fbcc54dd77c80bafff30dce7e
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-22T08:18:08Z
Merge pull request #2 from apache/master
Merge from trunk to caofangkun
commit cad1505deb214facb0fb70e24034e30f79a973da
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-24T03:44:25Z
STORM-596: remove config topology.receiver.buffer.size
commit 986ad60bf065c8c3dd965b5c2cfd33d71229385b
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-24T03:56:12Z
STORM-596: rm defaults.yaml.orig Config.java.orig
----
> "topology.receiver.buffer.size" has no effect
> ----------------------------------------------
>
> Key: STORM-596
> URL: https://issues.apache.org/jira/browse/STORM-596
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0, 0.9.3-rc2
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
>
> https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/messaging/loader.clj#L27
> backtype.storm.messaging.loader#mk-receive-thread accepts max-buffer-size as an input but the value isn't used within the function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)