You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2018/09/17 16:10:00 UTC
[jira] [Resolved] (ARROW-3242) [C++] Use coarser-grained dispatch
to SIMD hash functions
[ https://issues.apache.org/jira/browse/ARROW-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-3242.
---------------------------------
Resolution: Fixed
Issue resolved by pull request 2571
[https://github.com/apache/arrow/pull/2571]
> [C++] Use coarser-grained dispatch to SIMD hash functions
> ---------------------------------------------------------
>
> Key: ARROW-3242
> URL: https://issues.apache.org/jira/browse/ARROW-3242
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.11.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The way that we dispatch to SSE4 hash functions is a remnant from the Impala codebase, which checks CpuInfo on every iteration in debug builds:
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/hash-util.h#L43
> However, the static {{model_name_}} member is causing some non-determinism related to static member lifetime as reported in ARROW-3241.
> I'm proposing to refactor CpuInfo into a singleton pattern and handle SIMD vs non-SIMD dispatch at a higher level rather than at the lowest level like it is now. This should hopefully make the issue in ARROW-3241 go away
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)