You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2026/04/15 06:52:42 UTC

(lucene) branch main updated: Fix an assertion in TestExitableDirectoryReader to only trigger if the source doc values a SingletonSortedSetDocValues or SingletonSortedNumericDocValues. (#15955)

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/main by this push:
     new a36d275f468 Fix an assertion in TestExitableDirectoryReader to only trigger if the source doc values a SingletonSortedSetDocValues or SingletonSortedNumericDocValues. (#15955)
a36d275f468 is described below

commit a36d275f46856288440b9f1b90a215451186212d
Author: Dawid Weiss <da...@carrotsearch.com>
AuthorDate: Wed Apr 15 08:52:37 2026 +0200

    Fix an assertion in TestExitableDirectoryReader to only trigger if the source doc values a SingletonSortedSetDocValues or SingletonSortedNumericDocValues. (#15955)
---
 .../lucene/index/TestExitableDirectoryReader.java  | 37 +++++++++++-----------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java b/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
index 821f3c8f57b..37293b089c1 100644
--- a/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
+++ b/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
@@ -399,26 +399,25 @@ public class TestExitableDirectoryReader extends LuceneTestCase {
 
       // Test that singleton docValues stay as singleton docValues after filtering
       directoryReader = DirectoryReader.open(directory);
-      try (IndexReader reader = new TestReader(getOnlyLeafReader(directoryReader))) {
+      try (IndexReader reader = new TestReader(getOnlyLeafReader(directoryReader));
+          IndexReader exitableReader =
+              new TestReader(
+                  getOnlyLeafReader(
+                      new ExitableDirectoryReader(
+                          DirectoryReader.open(directory), infiniteQueryTimeout())))) {
         LeafReader leafReader = reader.leaves().getFirst().reader();
-        assertThat(
-            leafReader.getSortedSetDocValues("sortedset"),
-            Matchers.instanceOf(SingletonSortedSetDocValues.class));
-        assertThat(
-            leafReader.getSortedNumericDocValues("sortednumeric"),
-            Matchers.instanceOf(SingletonSortedNumericDocValues.class));
-      }
-      exitableDirectoryReader =
-          new ExitableDirectoryReader(DirectoryReader.open(directory), infiniteQueryTimeout());
-      try (IndexReader extitableReader =
-          new TestReader(getOnlyLeafReader(exitableDirectoryReader))) {
-        LeafReader exitableLeafReader = extitableReader.leaves().getFirst().reader();
-        assertThat(
-            exitableLeafReader.getSortedSetDocValues("sortedset"),
-            Matchers.instanceOf(SingletonSortedSetDocValues.class));
-        assertThat(
-            exitableLeafReader.getSortedNumericDocValues("sortednumeric"),
-            Matchers.instanceOf(SingletonSortedNumericDocValues.class));
+        LeafReader exitableLeafReader = exitableReader.leaves().getFirst().reader();
+        if (leafReader.getSortedSetDocValues("sortedset") instanceof SingletonSortedSetDocValues) {
+          assertThat(
+              exitableLeafReader.getSortedSetDocValues("sortedset"),
+              Matchers.instanceOf(SingletonSortedSetDocValues.class));
+        }
+        if (leafReader.getSortedNumericDocValues("sortednumeric")
+            instanceof SingletonSortedNumericDocValues) {
+          assertThat(
+              exitableLeafReader.getSortedNumericDocValues("sortednumeric"),
+              Matchers.instanceOf(SingletonSortedNumericDocValues.class));
+        }
       }
     }
   }