You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "littlexyw (via GitHub)" <gi...@apache.org> on 2025/04/23 07:49:43 UTC
[PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
littlexyw opened a new pull request, #3224:
URL: https://github.com/apache/celeborn/pull/3224
…lushBuffer
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Remove the redundant release of data after OutOfDirectMemoryError appears in flushBuffer.addComponent
### Why are the changes needed?
The reason why OutOfDirectMemoryError will appear in flushBuffer.addComponent is that after adding a new component, CompositeByteBuf will determine whether the number of components exceeds the maximum limit. If it exceeds, the existing components will be merged into a large component. At this time, new off-heap memory will be requested. If there is insufficient memory at this time, OutOfDirectMemoryError will be reported, but the new component has been added to flushBuffer at this time. Releasing the new component at this time will cause refcnt error.
Don't worry about the component here not being released causing memory leaks, because it will be released normally in returnBuffer (flush or file destroy or file close).
If writeLocalData does not catch OutOfDirectMemoryError, the impact is as follows:
1. In the case of a single copy, if https://github.com/apache/celeborn/pull/3049 pr is not merged, commitfile will be blocked in waitPendingWrites and fail, because writeLocalData does not correctly decrementPendingWrites. However, this will not cause flushBuffer to exist in memory for a long time, because when shuffle expires, the file will be destroyed, flushBuffer will be returned, and this part of memory will be released.
2. In the case of dual replicas, in addition to the above problems, the thread of the Eventloop to which replicate-client belongs will be blocked at Await.result(writePromise.future, Duration.Inf) because writePromise is not closed correctly. As a result, this thread will not process other PushData data written by PushServer to the channels of the Eventloop to which replicate-client belongs. This part of data accumulates in the taskQueue of EventLoop and cannot be canceled, which is the cause of memory leak.
Therefore, if the memory leak occurs after OutOfDirectMemoryError occurs in flushBuffer.addComponent, you only need to catch OutOfDirectMemoryError in writeLocalData, and there is no need to release data after addComponent.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] Remove redundant release on data added in flushBuffer [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2862482532
Merge to main(v0.6.0). Could you also backport this pr to branch-0.5 @littlexyw ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] Remove redundant release on data added in flushBuffer [celeborn]
Posted by "littlexyw (via GitHub)" <gi...@apache.org>.
littlexyw commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2862939312
> Merge to main(v0.6.0). Could you also backport this pr to branch-0.5 @littlexyw ?
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2829294882
Ping @leixm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] Remove redundant release on data added in flushBuffer [celeborn]
Posted by "littlexyw (via GitHub)" <gi...@apache.org>.
littlexyw commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2856910848
> For
>
> https://github.com/apache/celeborn/blob/a2110568f279c2714600b31e05708b7cb76e9936/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala#L317-L330
>
> We should not call `MemoryManager.instance.releaseMemoryFileStorage(buf.readableBytes())` in L323?
>
> https://github.com/apache/celeborn/blob/a2110568f279c2714600b31e05708b7cb76e9936/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala#L323
When OOM is thrown, buf.readableBytes should be calculated as if no exception was thrown, because buf has been added to flushBuffer. I submitted some new commits to this end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
Posted by "littlexyw (via GitHub)" <gi...@apache.org>.
littlexyw commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2823412914
I simulated the scenario where addCompoent had an OutOfDirectMemoryError, and released data after the OutOfDirectMemoryError occurred, and a refcnt error occurred.
`2025-04-23T09:50:44,889 [replicate-server-8-2] ERROR worker.PushDataHandler (Logging.scala:logError) - Exception encountered when write.
io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 164799 byte(s) of direct memory (used: 3221205392, max: 3221225472)
at io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:843) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:772) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:186) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledDirectByteBuf.<init>(UnpooledDirectByteBuf.java:64) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledUnsafeDirectByteBuf.<init>(UnpooledUnsafeDirectByteBuf.java:41) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.<init>(UnpooledUnsafeNoCleanerDirectByteBuf.java:25) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.<init>(UnpooledByteBufAllocator.java:181) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:91) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:188) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:179) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf.allocBuffer(CompositeByteBuf.java:1879) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf.consolidate0(CompositeByteBuf.java:1758) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf.consolidateIfNeeded(CompositeByteBuf.java:571) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf.addComponent(CompositeByteBuf.java:266) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf.addComponent(CompositeByteBuf.java:222) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at org.apache.celeborn.service.deploy.worker.storage.FileWriter.write(FileWriter.java:231) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.PushDataHandler.writeData$1(PushDataHandler.scala:1429) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.PushDataHandler.writeLocalData(PushDataHandler.scala:1486) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.PushDataHandler.handlePushData(PushDataHandler.scala:393) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.PushDataHandler.$anonfun$receive$1(PushDataHandler.scala:129) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.PushDataHandler.handleCore(PushDataHandler.scala:922) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.PushDataHandler.receive(PushDataHandler.scala:136) ~[classes/:?]
at org.apache.celeborn.common.network.server.TransportRequestHandler.processOtherMessages(TransportRequestHandler.java:132) ~[classes/:?]
at org.apache.celeborn.common.network.server.TransportRequestHandler.handle(TransportRequestHandler.java:88) ~[classes/:?]
at org.apache.celeborn.common.network.server.TransportChannelHandler.channelRead(TransportChannelHandler.java:156) ~[classes/:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[netty-handler-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at org.apache.celeborn.common.network.util.TransportFrameDecoder.channelRead(TransportFrameDecoder.java:74) ~[classes/:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_341]
2025-04-23T09:50:44,891 [replicate-server-8-2] WARN server.TransportChannelHandler (TransportChannelHandler.java:exceptionCaught) - Exception in connection from /10.23.168.125:54264
io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 65536 byte(s) of direct memory (used: 3221205392, max: 3221225472)
at io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:843) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:772) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:186) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledDirectByteBuf.<init>(UnpooledDirectByteBuf.java:64) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledUnsafeDirectByteBuf.<init>(UnpooledUnsafeDirectByteBuf.java:41) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.<init>(UnpooledUnsafeNoCleanerDirectByteBuf.java:25) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.<init>(UnpooledByteBufAllocator.java:181) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:91) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:188) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:179) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractByteBufAllocator.ioBuffer(AbstractByteBufAllocator.java:140) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.DefaultMaxMessagesRecvByteBufAllocator$MaxMessageHandle.allocate(DefaultMaxMessagesRecvByteBufAllocator.java:120) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:150) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) ~[netty-transport-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_341]
2025-04-23T09:50:44,896 [worker-memory-manager-checker] INFO memory.MemoryManager (MemoryManager.java:switchServingState) - Serving state transformed from PUSH_PAUSED to PUSH_AND_REPLICATE_PAUSED
2025-04-23T09:50:44,898 [worker-memory-manager-checker] INFO memory.MemoryManager (MemoryManager.java:switchServingState) - Trigger action: PAUSE REPLICATE
2025-04-23T09:50:44,898 [worker-memory-manager-checker] INFO memory.ChannelsLimiter (ChannelsLimiter.java:onPause) - replicate channels pause read.
2025-04-23T09:50:45,868 [worker-memory-manager-actor] INFO storage.StorageManager (Logging.scala:logInfo) - Trigger org.apache.celeborn.service.deploy.worker.storage.StorageManager trim action
2025-04-23T09:50:45,893 [LocalFlusher@943659381-/-4] ERROR util.Utils (Logging.scala:logError) - Uncaught exception in thread LocalFlusher@943659381-/-4
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
at io.netty.util.internal.ReferenceCountUpdater.toLiveRealRefCnt(ReferenceCountUpdater.java:83) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.util.internal.ReferenceCountUpdater.release(ReferenceCountUpdater.java:148) ~[netty-common-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:101) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractDerivedByteBuf.release0(AbstractDerivedByteBuf.java:98) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.AbstractDerivedByteBuf.release(AbstractDerivedByteBuf.java:94) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf$Component.free(CompositeByteBuf.java:1959) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at io.netty.buffer.CompositeByteBuf.removeComponents(CompositeByteBuf.java:650) ~[netty-buffer-4.1.101.Final.jar:4.1.101.Final]
at org.apache.celeborn.service.deploy.worker.storage.Flusher.returnBuffer(Flusher.scala:118) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.storage.Flusher$$anon$1.$anonfun$run$3(Flusher.scala:90) ~[classes/:?]
at org.apache.celeborn.common.util.Utils$.tryLogNonFatalError(Utils.scala:230) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.storage.Flusher$$anon$1.$anonfun$run$1(Flusher.scala:90) ~[classes/:?]
at scala.runtime.java8.JFunction0$mcI$sp.apply(JFunction0$mcI$sp.java:23) ~[scala-library-2.12.15.jar:?]
at org.apache.celeborn.common.metrics.source.AbstractSource.sample(AbstractSource.scala:199) ~[classes/:?]
at org.apache.celeborn.common.metrics.source.AbstractSource.sample(AbstractSource.scala:189) ~[classes/:?]
at org.apache.celeborn.service.deploy.worker.storage.Flusher$$anon$1.run(Flusher.scala:68) ~[classes/:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_341]
at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266) ~[?:1.8.0_341]
at java.util.concurrent.FutureTask.run(FutureTask.java) ~[?:1.8.0_341]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_341]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_341]
at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_341]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
Posted by "littlexyw (via GitHub)" <gi...@apache.org>.
littlexyw commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2823623789
At the same time, I simulated the scenario where addCompoent had an OutOfDirectMemoryError and did not release data after the OutOfDirectMemoryError occurred. No refcnt error occurred, commitfiles succeeded, the spark task succeeded, and after commitfiles, the worker diskbuffercount became 0.
[celeborn_1760_followup_worker.log](https://github.com/user-attachments/files/19864486/celeborn_1760_followup_worker.log)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2836917483
For
https://github.com/apache/celeborn/blob/a2110568f279c2714600b31e05708b7cb76e9936/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala#L317-L330
We should not call `MemoryManager.instance.releaseMemoryFileStorage(buf.readableBytes())` in L323?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] Remove redundant release on data added in flushBuffer [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #3224: [CELEBORN-1760][FOLLOWUP] Remove redundant release on data added in flushBuffer
URL: https://github.com/apache/celeborn/pull/3224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2829297226
@littlexyw Thanks for this PR. Your description is clear and makes sense. Can you provide some worker metrics for this PR, especially for the scenario in which the worker throws OOM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1760][FOLLOWUP] remove redundant release on data added in flushBuffer [celeborn]
Posted by "littlexyw (via GitHub)" <gi...@apache.org>.
littlexyw commented on PR #3224:
URL: https://github.com/apache/celeborn/pull/3224#issuecomment-2829433896
> @littlexyw Thanks for this PR. Your description is clear and makes sense. Can you provide some worker metrics for this PR, especially for the scenario in which the worker throws OOM?
<img width="1990" alt="企业微信截图_68dd45ce-f8f6-4cff-baae-87e00b126b57" src="https://github.com/user-attachments/assets/0217e4bb-6e05-497f-a73e-e810f76ecab7" />
<img width="2468" alt="企业微信截图_a7958a71-c6b7-4af3-b287-32501e0c595b" src="https://github.com/user-attachments/assets/857ff10a-36ff-4071-bf4a-8fe83cf7b84c" />
<img width="2473" alt="企业微信截图_7d1a3ad4-6d6d-4251-bc06-e2cc932e9527" src="https://github.com/user-attachments/assets/eedef517-37e2-430e-b5c7-b09cc2736dc9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org