You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (JIRA)" <ji...@apache.org> on 2011/09/19 14:59:09 UTC
[jira] [Created] (ZOOKEEPER-1193) Remove upgrade code
Remove upgrade code
-------------------
Key: ZOOKEEPER-1193
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
Project: ZooKeeper
Issue Type: Task
Reporter: Thomas Koch
Priority: Minor
ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Patrick Hunt (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-1193.
-------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
committed to trunk. It seems that we always regenerate the release notes as part of creating a release - I've left the current rel notes as is.
thanks Thomas!
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1193.patch
>
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132590#comment-13132590 ]
Hudson commented on ZOOKEEPER-1193:
-----------------------------------
Integrated in ZooKeeper-trunk #1339 (See [https://builds.apache.org/job/ZooKeeper-trunk/1339/])
ZOOKEEPER-1193. Remove upgrade code (Thomas Koch via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186916
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.sh
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WatchManager.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/upgrade
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/InvalidSnapshotTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/UpgradeTest.java
* /zookeeper/trunk/src/zookeeper.jute
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1193.patch
>
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Thomas Koch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131454#comment-13131454 ]
Thomas Koch commented on ZOOKEEPER-1193:
----------------------------------------
I've tried to understand the forrest documentation build process. The only site that seems to contain anything related to upgrade, is releasenotes. However the releasenotes site at http://zookeeper.apache.org/doc/current/releasenotes.html differs totally from src/docs/src/documentation/content/xdocs/releasenotes.xml
Could you (or any committer) please be so kind to do the necessary documentation changes?
BTW: It's confusing to have the generated docs directory committed to SVN. Don't you agree that it's best practice not to have generated stuff under version control?
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1193.patch
>
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131721#comment-13131721 ]
Patrick Hunt commented on ZOOKEEPER-1193:
-----------------------------------------
Forrest has always been painful (e.g. up until recently required jdk5). As a consequence committers committed the generated docs to svn - so casual users of the source repo would have availability of the generated docs.
Sync up with Ben - iirc he wanted to move this over to Apache CMS anyway. Enter a jira for the project (ie remove forrest and replace with whatever we're going to - on second thought first check if there is on already).
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1193.patch
>
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1193:
-----------------------------------
Attachment: ZOOKEEPER-1193.patch
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1193.patch
>
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127648#comment-13127648 ]
Patrick Hunt commented on ZOOKEEPER-1193:
-----------------------------------------
I believe we can drop the Upgrade code (v2->v3) at this point, however we should not drop the concept of supporting future upgrades, which we will likely have to do at some point.
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Priority: Minor
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128458#comment-13128458 ]
Hadoop QA commented on ZOOKEEPER-1193:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499209/ZOOKEEPER-1193.patch
against trunk revision 1180217.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/622//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/622//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/622//console
This message is automatically generated.
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1193.patch
>
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1193) Remove upgrade code
Posted by "Thomas Koch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127391#comment-13127391 ]
Thomas Koch commented on ZOOKEEPER-1193:
----------------------------------------
DataTree.createNode has
if(parentCVersion == -1) ...
I was wondering, what this is about and found, that it's related to the upgrade code Search for calls to CreateTxn.setParentCVersion()!
There may be other places that make the current code more complicate and can be cleaned up, if we don't need the upgrade code anymore.
> Remove upgrade code
> -------------------
>
> Key: ZOOKEEPER-1193
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1193
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Priority: Minor
>
> ZOOKEEPER-5 introduced the upgrade feature in october 2008. It may be time to think whether there are still installations in the wild that needs this upgrade feature. Otherwise the respective code can be removed.
> Even if there should be old installations, couldn't they just use some ZK 3.x version to upgrade and we could still remove the upgrade code from the trunk?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira