You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/19 10:40:51 UTC

[GitHub] [pulsar] Technoboy- opened a new pull request, #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Technoboy- opened a new pull request, #18114:
URL: https://github.com/apache/pulsar/pull/18114

   
   Fixes #18112
   
   ### Motivation
   
   
   ### Documentation
   
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #18114:
URL: https://github.com/apache/pulsar/pull/18114#issuecomment-1461277947

   Hi @Technoboy-, why not change the constructor of the `RetentionPolicies`?
   
   So like:
   ```
       public RetentionPolicies(int retentionTimeInMinutes, long retentionSizeInMB) {
   ```
   
   `long` can be compatible with `int`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18114:
URL: https://github.com/apache/pulsar/pull/18114#issuecomment-1284210960

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18114?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18114](https://codecov.io/gh/apache/pulsar/pull/18114?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8712e18) into [master](https://codecov.io/gh/apache/pulsar/commit/6c65ca0d8a80bfaaa4d5869e0cea485f5c94369b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c65ca0) will **increase** coverage by `16.01%`.
   > The diff coverage is `54.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/18114/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/18114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18114       +/-   ##
   =============================================
   + Coverage     34.91%   50.93%   +16.01%     
   - Complexity     5707     8712     +3005     
   =============================================
     Files           607      607               
     Lines         53396    53408       +12     
     Branches       5712     5719        +7     
   =============================================
   + Hits          18644    27201     +8557     
   + Misses        32119    23177     -8942     
   - Partials       2633     3030      +397     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `50.93% <54.79%> (+16.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../pulsar/broker/service/AbstractBaseDispatcher.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Fic3RyYWN0QmFzZURpc3BhdGNoZXIuamF2YQ==) | `53.20% <ø> (+7.34%)` | :arrow_up: |
   | [...che/pulsar/broker/service/BacklogQuotaManager.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0JhY2tsb2dRdW90YU1hbmFnZXIuamF2YQ==) | `12.39% <0.00%> (+2.91%)` | :arrow_up: |
   | [.../service/SystemTopicBasedTopicPoliciesService.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N5c3RlbVRvcGljQmFzZWRUb3BpY1BvbGljaWVzU2VydmljZS5qYXZh) | `61.39% <0.00%> (+9.80%)` | :arrow_up: |
   | [.../pulsar/broker/stats/BrokerOperabilityMetrics.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9Ccm9rZXJPcGVyYWJpbGl0eU1ldHJpY3MuamF2YQ==) | `98.21% <ø> (+5.56%)` | :arrow_up: |
   | [...g/apache/pulsar/compaction/CompactedTopicImpl.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbXBhY3Rpb24vQ29tcGFjdGVkVG9waWNJbXBsLmphdmE=) | `69.28% <0.00%> (+58.57%)` | :arrow_up: |
   | [...va/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2pkYmMvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2pkYmMvSmRiY0Fic3RyYWN0U2luay5qYXZh) | `4.16% <0.00%> (-0.03%)` | :arrow_down: |
   | [...java/org/apache/pulsar/io/jdbc/JdbcSinkConfig.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2pkYmMvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2pkYmMvSmRiY1NpbmtDb25maWcuamF2YQ==) | `23.33% <0.00%> (-1.67%)` | :arrow_down: |
   | [...main/java/org/apache/pulsar/io/jdbc/JdbcUtils.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2pkYmMvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2pkYmMvSmRiY1V0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/pulsar/broker/admin/v2/Namespaces.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9OYW1lc3BhY2VzLmphdmE=) | `56.85% <50.00%> (+48.82%)` | :arrow_up: |
   | [...ache/pulsar/broker/service/EntryFilterSupport.java](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0VudHJ5RmlsdGVyU3VwcG9ydC5qYXZh) | `27.02% <50.00%> (+2.02%)` | :arrow_up: |
   | ... and [157 more](https://codecov.io/gh/apache/pulsar/pull/18114/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #18114:
URL: https://github.com/apache/pulsar/pull/18114#issuecomment-1285081547

   > Question: Why don't we choose `long`?
   
   `int` is enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18114:
URL: https://github.com/apache/pulsar/pull/18114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #18114:
URL: https://github.com/apache/pulsar/pull/18114#issuecomment-1283804310

   Also should modify `ManagedLedgerConfig.retentionSizeInMB` type.
   
   https://github.com/apache/pulsar/blob/7b53bd90604e80ed5653dcb9f9d4324d3d533d68/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java#L437-L440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #18114:
URL: https://github.com/apache/pulsar/pull/18114#issuecomment-1283809784

   > setRetentionSizeInMB
   
   
   
   > Also should modify `ManagedLedgerConfig.retentionSizeInMB` type.
   > 
   > https://github.com/apache/pulsar/blob/7b53bd90604e80ed5653dcb9f9d4324d3d533d68/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java#L437-L440
   
   applyed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #18114: [fix][broker] Fix RetentionPolicies types mismatch.

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #18114:
URL: https://github.com/apache/pulsar/pull/18114#issuecomment-1461283902

   > > Question: Why don't we choose `long`?
   > 
   > `int` is enough.
   
   I think we still should use the `long`, `long` can be compatible with `int`.
   
   @Technoboy- @mattisonchao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org