You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/03/31 21:32:14 UTC

[kudu-CR] [ranger] Use unique loopback for MiniRanger 

Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15625


Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
8 files changed, 44 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15625/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Apr 2020 19:24:53 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15625

to look at the new patch set (#3).

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
8 files changed, 44 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15625/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15625

to look at the new patch set (#6).

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres-test.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger-test.cc
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
10 files changed, 51 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15625/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15625/5/src/kudu/ranger/mini_ranger.h
File src/kudu/ranger/mini_ranger.h:

http://gerrit.cloudera.org:8080/#/c/15625/5/src/kudu/ranger/mini_ranger.h@158
PS5, Line 158: in REST API.
> nit: don't need this since all of our constructors set it.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Apr 2020 21:12:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc
File src/kudu/mini-cluster/external_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc@339
PS1, Line 339:     string host = GetBindIpForExternalServer(0);
Should add some comment here about why it's OK to use the same index as for Sentry (i.e. we'll never start a cluster with both).

Come to think of it, do we actually enforce that? We probably should.


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/util/net/net_util.h
File src/kudu/util/net/net_util.h:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/util/net/net_util.h@235
PS1, Line 235: // Gets a random port from the ephemeral range by binding to port 0 and letting
Update to reflect the effect of 'address'.



-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 23:02:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 10: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 02 Apr 2020 21:24:39 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15625

to look at the new patch set (#5).

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres-test.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger-test.cc
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
10 files changed, 51 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15625/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc
File src/kudu/mini-cluster/external_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc@339
PS1, Line 339:     ranger_.reset(new ranger::MiniRanger(cluster_root(), host));
> Should add some comment here about why it's OK to use the same index as for
we do enforce that: https://github.com/apache/kudu/blob/2e5db19b983c79ada74b7bd892f0b1fb32b045ce/src/kudu/master/catalog_manager.cc#L322-L330

added a comment


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc@339
PS1, Line 339: new ranger::MiniRanger(cluster_root(), host));
             :     // We're using the same 
> Do we ever expect to _not_ set this? How about putting this into MiniRanger
Done


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/postgres/mini_postgres.h
File src/kudu/postgres/mini_postgres.h:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/postgres/mini_postgres.h@69
PS1, Line 69:   }
            : 
            :   std::string pg_root() const {
            :    
> nit: not used?
Done


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/ranger/mini_ranger.h
File src/kudu/ranger/mini_ranger.h:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/ranger/mini_ranger.h@111
PS1, Line 111: 
             :  private:
             :   // Starts the Ranger service.
             :   Status StartRanger() WARN_UNUSED_RESULT;
             : 
> nit: not used?
Done


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/util/net/net_util.h
File src/kudu/util/net/net_util.h:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/util/net/net_util.h@235
PS1, Line 235: // Gets a random port from the ephemeral range by binding to port 0 on address
> Update to reflect the effect of 'address'.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Apr 2020 09:25:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Reviewed-on: http://gerrit.cloudera.org:8080/15625
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres-test.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger-test.cc
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
10 files changed, 51 insertions(+), 31 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved
  Adar Dembo: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc
File src/kudu/mini-cluster/external_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc@339
PS1, Line 339: GetBindIpForExternalServer(0);
             :     ranger_->set_host(host);
Do we ever expect to _not_ set this? How about putting this into MiniRanger's constructor? That'd make Ranger's usage of 'host_' a bit more straightforward since it could be made const. Or we could make the host an argument of Start() for both MiniRanger and MiniPostgres.


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/postgres/mini_postgres.h
File src/kudu/postgres/mini_postgres.h:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/postgres/mini_postgres.h@69
PS1, Line 69: 
            :   void set_port(uint16_t port) {
            :     port_ = port;
            :   }
nit: not used?


http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/ranger/mini_ranger.h
File src/kudu/ranger/mini_ranger.h:

http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/ranger/mini_ranger.h@111
PS1, Line 111: 
             :   void set_port(uint16_t port) {
             :     port_ = port;
             :   }
             : 
nit: not used?



-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 22:53:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15625

to look at the new patch set (#2).

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
8 files changed, 44 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15625/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15625

to look at the new patch set (#4).

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................

[ranger] Use unique loopback for MiniRanger

Other services use a unique loopback address on Linux systems to avoid
conflicting ports. This patch changes Ranger and Postgres to use this
unique loopback as well. Unfortunately as Ranger starts up Tomcat
without specifying the bind address, it always listens to all
interfaces.  Because of this the unique loopback trick is not enough in
itself and the randomized port number is also used in this case.

Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/postgres/mini_postgres-test.cc
M src/kudu/postgres/mini_postgres.cc
M src/kudu/postgres/mini_postgres.h
M src/kudu/ranger/mini_ranger-test.cc
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
10 files changed, 49 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15625/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Apr 2020 21:45:47 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/postgres/mini_postgres.h
File src/kudu/postgres/mini_postgres.h:

http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/postgres/mini_postgres.h@40
PS2, Line 40:     : MiniPostgres(GetTestDataDirectory(), std::move(host)) {}
> warning: parameter 'host' is passed by value and only copied once; consider
Done


http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/ranger/mini_ranger.h
File src/kudu/ranger/mini_ranger.h:

http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/ranger/mini_ranger.h@67
PS2, Line 67:     : MiniRanger(GetTestDataDirectory(), std::move(host)) {}
> warning: parameter 'host' is passed by value and only copied once; consider
Done


http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/ranger/mini_ranger.h@74
PS2, Line 74:       mini_pg_(data_root_, host_),
> warning: Moved-from object 'host' of type 'std::basic_string' is copied [cl
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Apr 2020 12:02:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 02 Apr 2020 17:01:11 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Apr 2020 21:48:58 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] Use unique loopback for MiniRanger

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )

Change subject: [ranger] Use unique loopback for MiniRanger
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15625/5/src/kudu/ranger/mini_ranger.h
File src/kudu/ranger/mini_ranger.h:

http://gerrit.cloudera.org:8080/#/c/15625/5/src/kudu/ranger/mini_ranger.h@158
PS5, Line 158: = "127.0.0.1";
nit: don't need this since all of our constructors set it.



-- 
To view, visit http://gerrit.cloudera.org:8080/15625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 01 Apr 2020 20:53:07 +0000
Gerrit-HasComments: Yes