You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/11 03:23:37 UTC
[GitHub] [arrow] guyuqi opened a new pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
guyuqi opened a new pull request #12398:
URL: https://github.com/apache/arrow/pull/12398
Benchmark:
Before:
```
BenchmarkPlainEncodingBoolean/len_1024-64 292210 4084 ns/op 250.74 MB/s
BenchmarkPlainEncodingBoolean/len_2048-64 179871 6669 ns/op 307.10 MB/s
BenchmarkPlainEncodingBoolean/len_4096-64 101024 11895 ns/op 344.35 MB/s
BenchmarkPlainEncodingBoolean/len_8192-64 53070 22599 ns/op 362.49 MB/s
BenchmarkPlainEncodingBoolean/len_16384-64 26664 45060 ns/op 363.60 MB/s
BenchmarkPlainEncodingBoolean/len_32768-64 13353 89844 ns/op 364.72 MB/s
BenchmarkPlainEncodingBoolean/len_65536-64 6663179439 ns/op 365.23 MB/s
```
After:
```
BenchmarkPlainEncodingBoolean/len_1024-64 414085 2898 ns/op 353.32 MB/s
BenchmarkPlainEncodingBoolean/len_2048-64 217814 5485 ns/op 373.39 MB/s
BenchmarkPlainEncodingBoolean/len_4096-64 112413 10678 ns/op 383.60 MB/s
BenchmarkPlainEncodingBoolean/len_8192-64 57085 21012 ns/op 389.87 MB/s
BenchmarkPlainEncodingBoolean/len_16384-64 28668 41854 ns/op 391.46 MB/s
BenchmarkPlainEncodingBoolean/len_32768-64 14356 83565 ns/op 392.13 MB/s
BenchmarkPlainEncodingBoolean/len_65536-64 7149166811 ns/op 392.88 MB/s
```
Get 7% ~ 40% performance uplift.
Tests in parquet/internal/encoding:
```
ARM_ENABLE_EXT=NEON go test
PASS
ok github.com/apache/arrow/go/v7/parquet/internal/encoding 9.949s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1050054321
Benchmark runs are scheduled for baseline = 356dba43f0019c89b02be98d983bcddf2db5f586 and contender = ff9293007129f7dd16435c696e988832ab08170f. ff9293007129f7dd16435c696e988832ab08170f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0aa0c473c4a4a10a41d84c4b672c84d...a7f27095cc1c405e971dcb8d32950704/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9f1767c1f7c24a23b0605fd96f2508a6...97d3d56642844ed5b4405cffce3f8c28/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bcab748d67a041c5a098e253391ef524...9de5b91a2d614518a39797c6f3830d57/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1122f338ed1f42739433d17b571a0b95...d4c71d88e96144309ca1e4f97ecf0eea/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1039759352
@zeroshade Could you please have a look this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1039759352
@zeroshade Could you please have a look this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1050054321
Benchmark runs are scheduled for baseline = 356dba43f0019c89b02be98d983bcddf2db5f586 and contender = ff9293007129f7dd16435c696e988832ab08170f. ff9293007129f7dd16435c696e988832ab08170f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0aa0c473c4a4a10a41d84c4b672c84d...a7f27095cc1c405e971dcb8d32950704/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9f1767c1f7c24a23b0605fd96f2508a6...97d3d56642844ed5b4405cffce3f8c28/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bcab748d67a041c5a098e253391ef524...9de5b91a2d614518a39797c6f3830d57/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1122f338ed1f42739433d17b571a0b95...d4c71d88e96144309ca1e4f97ecf0eea/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12398:
URL: https://github.com/apache/arrow/pull/12398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1050054321
Benchmark runs are scheduled for baseline = 356dba43f0019c89b02be98d983bcddf2db5f586 and contender = ff9293007129f7dd16435c696e988832ab08170f. ff9293007129f7dd16435c696e988832ab08170f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0aa0c473c4a4a10a41d84c4b672c84d...a7f27095cc1c405e971dcb8d32950704/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9f1767c1f7c24a23b0605fd96f2508a6...97d3d56642844ed5b4405cffce3f8c28/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bcab748d67a041c5a098e253391ef524...9de5b91a2d614518a39797c6f3830d57/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1122f338ed1f42739433d17b571a0b95...d4c71d88e96144309ca1e4f97ecf0eea/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1035847904
https://issues.apache.org/jira/browse/ARROW-15440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12398: ARROW-15440: [Go] Implement 'unpack_bool' with Arm64 GoLang Assembly
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12398:
URL: https://github.com/apache/arrow/pull/12398#issuecomment-1050054321
Benchmark runs are scheduled for baseline = 356dba43f0019c89b02be98d983bcddf2db5f586 and contender = ff9293007129f7dd16435c696e988832ab08170f. ff9293007129f7dd16435c696e988832ab08170f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0aa0c473c4a4a10a41d84c4b672c84d...a7f27095cc1c405e971dcb8d32950704/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9f1767c1f7c24a23b0605fd96f2508a6...97d3d56642844ed5b4405cffce3f8c28/)
[Finished :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bcab748d67a041c5a098e253391ef524...9de5b91a2d614518a39797c6f3830d57/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1122f338ed1f42739433d17b571a0b95...d4c71d88e96144309ca1e4f97ecf0eea/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org