Re: [PR] feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean [activemq]

["jbonofre (via GitHub)" <gi...@apache.org>]

jbonofre commented on code in PR #1829:
URL: https://github.com/apache/activemq/pull/1829#discussion_r2988007508


##########
activemq-broker/src/main/java/org/apache/activemq/network/MulticastNetworkConnector.java:
##########
@@ -77,6 +77,11 @@ public void setRemoteTransport(Transport remoteTransport) {
         this.remoteTransport = remoteTransport;
     }
 
+    @Override
+    public URI getUri() {
+        return remoteURI;

Review Comment:
   I know it's redundant with `getRemoteURI()` here, but it's for consistency.
   
   I'm fine to use `getRemoveURI()` everywhere if it makes more sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact