[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #277: Remove continue-on-error from github actions

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #277: Remove continue-on-error from github actions
URL: https://github.com/apache/incubator-daffodil/pull/277#discussion_r335085843
 
 

 ##########
 File path: daffodil-lib/src/test/scala/org/apache/daffodil/xml/test/unit/TestXMLUtils.scala
 ##########
 @@ -284,7 +284,7 @@ class TestXMLUtils {
   @Test def testBlobDiff01() {
     val path1 = createBlobFile("A1B2C3")
     val path2 = createBlobFile("A1B2C3")
-    val diff = XMLUtils.computeBlobDiff("path", path1.toString, path2.toString)
+    val diff = XMLUtils.computeBlobDiff("path", path1.toUri.toString, path2.toUri.toString)
 
 Review comment:
   When I made the PR, I didn't realize there were actual failures (I noticed this originally in another PR that did have failures). But it turned out, we've had tests failing on windows for a while and I didn't notice until the option was removed and a build happened. Since it was kindof related, I quickly fix the tests so they'd pass on windows. I'll fix the commit message when I squash everything together once all the tests pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services